Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cubesql): Fix date split column dependency #8311

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

MazterQyou
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR fixes column dependency in date splits, allows splitting with non-comparable granularities, and adds a DATE_PART(CAST(DATE_TRUNC(...))) split variant.

@MazterQyou MazterQyou requested a review from a team as a code owner May 29, 2024 21:21
@MazterQyou MazterQyou force-pushed the cubesql/fix-date-part-split-column-dependency branch from aa2af1d to 02ab6f2 Compare July 10, 2024 11:03
Copy link

vercel bot commented Jul 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2024 11:04am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2024 11:04am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2024 11:04am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2024 11:04am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2024 11:04am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2024 11:04am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2024 11:04am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2024 11:04am
@MazterQyou MazterQyou merged commit 5638f70 into master Jul 11, 2024
75 checks passed
@MazterQyou MazterQyou deleted the cubesql/fix-date-part-split-column-dependency branch July 11, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants