Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(schema-compiler) Resolve rollup join pre-aggregation param allocator issue #8279

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

fix(schema-compiler) Resolve rollup join pre-aggregation param allocator issue #8279

Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1406add
fix(schema-compiler) Resolve rollup join pre-aggregation param alloca…
pauldheinrichs May 19, 2024
660e7f2
re add default return
pauldheinrichs May 21, 2024
d4ae4a9
clean up comments and initalization
pauldheinrichs May 21, 2024
bc895df
Remove these logging
pauldheinrichs May 21, 2024
a009a0e
unset here too!
pauldheinrichs May 23, 2024
52aa3c1
had it backwards
pauldheinrichs May 23, 2024
9f3c5ce
Revert "had it backwards"
pauldheinrichs Jun 24, 2024
57c31b2
Revert "unset here too!"
pauldheinrichs Jun 24, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions packages/cubejs-schema-compiler/src/adapter/BaseQuery.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2651,13 +2651,18 @@ export class BaseQuery {

newSubQuery(options) {
const QueryClass = this.constructor;
return new QueryClass(this.compilers, this.subQueryOptions(options));
return new QueryClass(this.compilers, { ...this.subQueryOptions(options), paramAllocator: undefined });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't unset param allocator here as it should reused in case of actual sub_query: true members.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would you recommend here then, reverting the last commit and pushing forward with just the initial implementation?
}

newSubQueryForCube(cube, options) {
return this.options.queryFactory
? this.options.queryFactory.createQuery(cube, this.compilers, this.subQueryOptions(options))
: this.newSubQuery(options);
if (this.options.queryFactory) {
// When dealing with rollup joins, it's crucial to use the correct parameter allocator for the specific cube in use.
// By default, we'll use BaseQuery, but it's important to note that different databases (Oracle, PostgreSQL, MySQL, Druid, etc.)
// have unique parameter allocator symbols. Using the wrong allocator can break the query, especially when rollup joins involve
// different cubes that require different allocators.
return this.options.queryFactory.createQuery(cube, this.compilers, { ...this.subQueryOptions(options), paramAllocator: undefined });
Copy link
Author

@pauldheinrichs pauldheinrichs May 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unset the paramAllocator set by this.subQueryOptions to allow QueryClasses to assume their default paramAllocator class
}
return this.newSubQuery(options);
}

subQueryOptions(options) {
Expand Down
Loading