Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We��ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oracle datetime cast #7510

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Oracle datetime cast #7510

wants to merge 21 commits into from

Conversation

kenstott
Copy link

@kenstott kenstott commented Dec 9, 2023 •
edited
Loading

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

Resolves Issue# 4374

Description of Changes Made (if issue reference is not ###provided)

In addition to the above issue.

  1. Resolved a problem with grouping dates by quarter.
  2. Resolved issue with graphql inDateRange operators nested within and/or clauses
@kenstott kenstott requested a review from a team as a code owner December 9, 2023 01:54
@vercel Vercel
Copy link

vercel bot commented Dec 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2024 6:55pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2024 6:55pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2024 6:55pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2024 6:55pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2024 6:55pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2024 6:55pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2024 6:55pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2024 6:55pm
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Dec 9, 2023
@kenstott
Copy link
Author

kenstott commented Dec 9, 2023

Had to reopen due to merge issue. Same as this PR
@kenstott
Copy link
Author

Would love to get this merged. Let me know if I need to do anything else to make this happen.
@kenstott kenstott requested a review from a team as a code owner December 18, 2023 19:49
@paveltiunov
Copy link
Member

@kenstott Thanks for contributing! Could you please also add a smoke test for this test? I feel we need to test it against actual Oracle DB instance.
@paveltiunov paveltiunov self-assigned this Dec 21, 2023
@kenstott
Copy link
Author

I have successfully tested it with an instance of oracle express - and an instance of oracle exadata. Not quite sure what you are looking for.
@igorlukanin igorlukanin added the driver:oracle Issues relating to the Oracle driver label Jan 5, 2024
@paveltiunov
Copy link
Member

@kenstott That's great to hear! Could you please provide an automated E2E test for this change that reproduces the same? We require tests to be included with most of the contributions. Please see https://github.com/cube-js/cube/blob/master/CONTRIBUTING.md#step-by-step-guide-to-contributing.
@kenstott
Copy link
Author

done.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
driver:oracle Issues relating to the Oracle driver pr:community Contribution from Cube.js community members.
4 participants
@kenstott @paveltiunov @igorlukanin @kstott