Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(preaggr): Remove unused paramerers. #4719

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

cristipp
Copy link
Contributor

@cristipp cristipp commented Jun 6, 2022

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

N/A

Description of Changes Made (if issue reference is not provided)

  • Removes unnecessary preAggregation parameter to methods of PreAggregationLoader.
  • Removes unnecessary nested closure in PreAggregationLoader.refresh.
@cristipp cristipp requested a review from a team as a code owner June 6, 2022 21:19
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Jun 6, 2022
@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Base: 81.63% // Head: 59.24% // Decreases project coverage by -22.38% ⚠️

Coverage data is based on head (6a02ad3) compared to base (22befff).
Patch coverage: 91.66% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4719       +/-   ##
===========================================
- Coverage   81.63%   59.24%   -22.39%     
===========================================
  Files         115      136       +21     
  Lines       15835    11168     -4667     
  Branches        0     2773     +2773     
===========================================
- Hits        12927     6617     -6310     
- Misses       2908     4045     +1137     
- Partials        0      506      +506     
Flag Coverage Δ
cube-backend 59.24% <91.66%> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...y-orchestrator/src/orchestrator/PreAggregations.ts 81.26% <91.66%> (ø)
...pile/engine/information_schema/postgres/pg_type.rs
...cubesql/cubesql/src/compile/rewrite/rules/split.rs
rust/cubesql/cubesql/src/sql/types.rs
rust/cubesql/cubesql/src/compile/context.rs
...pile/engine/information_schema/postgres/pg_enum.rs
rust/cubesql/cubesql/src/telemetry/mod.rs
rust/cubesql/cubesql/src/compile/engine/udf.rs
...gine/information_schema/postgres/character_sets.rs
rust/cubesql/cubeclient/src/apis/configuration.rs
... and 242 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rpaik rpaik removed the pr:community Contribution from Cube.js community members. label Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants