fix: dimensionColumns only fetch string column #2533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimensionColumns method delete `&& this.columnType(column) === 'string'` otherwise always only fetch string type column
github-actions
bot
added
the
pr:community
|
@vasilev-alex can you help with the review? |
vasilev-alex
approved these changes
Apr 20, 2021
vasilev-alex
requested changes
Apr 20, 2021
There was a problem hiding this comment.
Hi @rongfengliang! Thanks for the PR. Could you please fix the failing tests?
ok. i will try to fix it |
|
👋 @rongfengliang I assume you're still working on this? Let us know if you have any questions 😄 |
i found should modify many unit test. current I'm a little busy. if i have time i will fix it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dimensionColumns method delete
&& this.columnType(column) === 'string'otherwise cube.js playground with schema generater will always only fetch string type column