Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cubestore): add CREATE DATABASE and SHOW DATABASES aliases for CREATE SCHEMA and SHOW SCHEMAS #1451

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(cubestore): add CREATE DATABASE and SHOW DATABASES aliases for CREATE SCHEMA and SHOW SCHEMAS #1451

wants to merge 1 commit into from

Conversation

spachev
Copy link

@spachev spachev commented Nov 25, 2020

Check List

  • [y ] Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • [ y] Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

MySQL historically has been using CREATE DATABASE / SHOW DATABASES instead of CREATE SCHEMA / SHOW SCHEMA. The change adds those aliases to be compatible with the applications using the original MySQL syntax.
@spachev spachev requested a review from a team as a code owner November 25, 2020 18:53
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Nov 25, 2020
@hassankhan hassankhan changed the title CREATE DATABASE and SHOW DATABASES aliases for CREATE SCHEMA and SHOW SCHEMAS Nov 30, 2020
@rpaik rpaik added this to In Progress in Roadmap 2020 Q4 Dec 11, 2020
@rpaik rpaik linked an issue Dec 11, 2020 that may be closed by this pull request
Epic: Cube Store #1334
Closed
4 tasks
@keydunov keydunov removed this from In Progress in Roadmap 2020 Q4 Dec 28, 2020
@paveltiunov paveltiunov requested a review from a team as a code owner November 5, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
2 participants
@spachev @paveltiunov