Fix video player controller

cloudinary · Mar 17, 2024 · b841da5 · b841da5
1 parent b0a9732
commit b841da5
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/lib/video/cld_video_controller.dart b/lib/video/cld_video_controller.dart
@@ -85,7 +85,7 @@ class CldVideoController extends VideoPlayerController
     ((assetType != null) ? video.assetType(assetType) : null);
     ((deliveryType != null) ? video.deliveryType(deliveryType) : null);
 
-    if ((automaticStreamingProfile == null || automaticStreamingProfile) &&
+    if ((automaticStreamingProfile != null && automaticStreamingProfile) &&
         transformation == null) {
       video.transformation(Transformation()
           .transcode(Transcode.streamingProfile(StreamingProfile.auto())));

diff --git a/test/cld_video_controller_test.dart b/test/cld_video_controller_test.dart
@@ -95,6 +95,24 @@ void main() {
         cloudinary: cloudinary,
       );
 
+      final String expectedUriString =
+          'https://res.cloudinary.com/test/video/upload/'
+          'sample_public_id';
+      expect(controller.dataSource.toString(), expectedUriString);
+    });
+
+    test(
+        'CldVideoController constructor builds correct URI with specific cloudinary and automatic streaming profile',
+        () {
+      Cloudinary cloudinary = CloudinaryObject.fromCloudName(cloudName: "test");
+      cloudinary.config.urlConfig.analytics = false;
+      final String publicId = 'sample_public_id';
+
+      final CldVideoController controller = CldVideoController(
+          publicId: publicId,
+          cloudinary: cloudinary,
+          automaticStreamingProfile: true);
+
       final String expectedUriString =
           'https://res.cloudinary.com/test/video/upload/sp_auto/'
           'sample_public_id.m3u8';