Remove Default 2-Stage Image Sizing #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
… responsive images rework
github-actions bot
pushed a commit
that referenced
this pull request
Feb 22, 2024
# [6.0.0-beta.9](v6.0.0-beta.8...v6.0.0-beta.9) (2024-02-22) ### Features * Remove Default 2-Stage Image Sizing ([#431](#431)) ([b8de6f0](b8de6f0)) ### BREAKING CHANGES * Changes how cropping fundamentally works, introduces new functionality behind crop prop
|
🎉 This PR is included in version 6.0.0-beta.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 6.0.0-beta.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
colbyfayock
added a commit
that referenced
this pull request
Feb 26, 2024
# Description * Migrates project to pnpm ### CldImage, getCldImageUrl, CldOgImage, getCldOgImageUrl * Removes default 2-stage resizing to avoid low resolution images for larger source images * #327 * #431 * #432 ### CldImage * Deprecates `transformations` in favor of `namedTransformations` ### getCldImageUrl * Removes types GetCldImageUrl and GetCldOgImageUrl ### CldUploadWidget * Add Content-Type to CldUploadWidget signature endpoint * Deprecates some CldUploadWidget types in favor of natively defined types from @cloudinary-util/types * CldUploadWidgetInfo, CldUploadWidgetPropsOptions, CldUploadWidgetResults ### CldVideoPlayer * Removes `autoPlay` in favor of `autoplay` * Video Player: CldVideoPlayerPropsColors * Deprecates some CldVideoPlayer types in favor of natively defined types from @cloudinary-util/types * CldVideoPlayerPropsColors ## Post-Release TODO - [ ] Update cloudinary-examples - Signed CldUploadWidget upload endpoints ## Issue Ticket Number Fixes #363 Fixes #379 Fixes #419 Fixes #327 ## Type of change <!-- Please select all options that are applicable. --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Fix or improve the documentation - [ ] This change requires a documentation update # Checklist <!-- These must all be followed and checked. --> - [ ] I have followed the contributing guidelines of this project as mentioned in [CONTRIBUTING.md](/CONTRIBUTING.md) - [ ] I have created an [issue](https://github.com/cloudinary-community/next-cloudinary/issues) ticket for this PR - [ ] I have checked to ensure there aren't other open [Pull Requests](https://github.com/cloudinary-community/next-cloudinary/pulls) for the same update/change? - [ ] I have performed a self-review of my own code - [ ] I have run tests locally to ensure they all pass - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes needed to the documentation BREAKING CHANGE: Removes 2-stage cropping and resizing, type and prop deprecations, and more - see Changelog on next.cloudinary.dev
|
🎉 This PR is included in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the 2-stage image sizing that occurs on URLs generated via the image component and helpers to avoid producing lower resolution images that necessary for images with a larger original source.
Instead, this primarily provides a post-transformation resize mechanism and a new
cropAPI that provides the ability to customize how crops are applied.In an original example of:
The resulting URL may look like:
This would always restrict the resulting image from being no larger than the initial width, which is based on the desired render size, not the original image's source size.
With the new crop API, by using:
The resulting URL may look like:
And to replicate the original 2-stage effect, you can do:
Where the resulting URL may look like:
Please see the RFC for more context and reasoning: #432