Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #57: enable concurrency #89

Merged
merged 6 commits into from
Nov 7, 2023
Merged

Closes #57: enable concurrency #89

merged 6 commits into from
Nov 7, 2023

Conversation

matiasfha
Copy link
Collaborator

@matiasfha matiasfha commented Oct 30, 2023 •
edited
Loading

Description

Enable a concurrency parameter to allow users to concurrently upload assets

Issue Ticket Number

Closes #57

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have created an issue ticket for this PR
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have run tests locally to ensure they all pass
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation
@netlify
Copy link

netlify bot commented Oct 30, 2023 •
edited
Loading

✅ Deploy Preview for netlify-plugin-cloudinary ready!

Name Link
🔨 Latest commit d54d9f6
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-cloudinary/deploys/654aab77cf61b3000824dc99
😎 Deploy Preview https://deploy-preview-89--netlify-plugin-cloudinary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.
@colbyfayock
Copy link
Collaborator

colbyfayock commented Nov 7, 2023 •
edited
Loading

i updated the project from Jest to Vitest and merged it into this. the problem isn't only Jest, it's that the plugin isnt currently set up as an ESM package. i installed the 3.x version which works

had to make a few other tweaks but got this working

thanks Matias
@colbyfayock colbyfayock merged commit 6a8d70f into cloudinary-community:main Nov 7, 2023
8 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 7, 2023
@semantic-release-bot
chore(release): 1.13.0 [skip ci]
df8c8c9 
# [1.13.0](v1.12.0...v1.13.0) (2023-11-07)

### Features

* Concurrency ([#89](#89)) ([6a8d70f](6a8d70f)), closes [#57](#57)
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023

🎉 This PR is included in version 1.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀
This was referenced Nov 7, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released
2 participants
@matiasfha @colbyfayock