Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump for React 17 #531

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Bump for React 17 #531

merged 1 commit into from
Oct 29, 2020

Conversation

levigunz
Copy link
Contributor

@levigunz levigunz commented Oct 23, 2020

Bump for React & React Dom 17
Updating both peer dependencies and devDependencies

Can also update website to React 17 if we want to do it at the same time.

Resolves #529

@ranneyd
Copy link

ranneyd commented Oct 29, 2020

Copy link
Owner

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. Unfortunately I can't actually test this change because the local test harness script no longer works.

$ yarn start

> react-window-docs@0.0.0 start /Users/bvaughn/Documents/git/react-window/website
> node scripts/start.js

Cannot destructure property 'compile' of 'compiler.hooks' as it is undefined.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! react-window-docs@0.0.0 start: `node scripts/start.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the react-window-docs@0.0.0 start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/bvaughn/.npm/_logs/2020-10-29T19_52_04_960Z-debug.log
@bvaughn
Copy link
Owner

bvaughn commented Oct 29, 2020

Doesn't seem related to this change though I guess so...

@bvaughn bvaughn merged commit c057b19 into bvaughn:master Oct 29, 2020
@bvaughn
Copy link
Owner

bvaughn commented Oct 29, 2020

Published to NPM as 1.8.6

@levigunz
Copy link
Contributor Author

levigunz commented Oct 29, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants