Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade fsevents from 1.2.3 to 1.2.13 #496

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

devrelm
Copy link

@devrelm devrelm commented Jul 15, 2020

fsevents v1.2.3 only has binaries available up to Node 10.

So when using Node 12.x+, it falls back to re-building fsevents from source. But that has its own set of issues that keeps it from working for some reason.

Upgrading fsevents to v1.2.13 appears to fix these issues.

Comment on lines 3769 to -3799
fsevents@^1.0.0, fsevents@^1.1.2, fsevents@^1.1.3:
version "1.2.3"
resolved "https://registry.yarnpkg.com/fsevents/-/fsevents-1.2.3.tgz#08292982e7059f6674c93d8b829c1e8604979ac0"
version "1.2.13"
resolved "https://registry.yarnpkg.com/fsevents/-/fsevents-1.2.13.tgz#f325cb0455592428bcf11b383370ef70e3bfcc38"
integrity sha512-oWb1Z6mkHIskLzEJ/XWX0srkpkTQ7vaopMQkyaEIoq0fmtFVxOthb8cCxeT+p3ynTdkk/RZwbgG4brR5BeWECw==
dependencies:
nan "^2.9.2"
node-pre-gyp "^0.9.0"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To generate the changes to the yarn.lock, I ultimately just removed these lines and ran yarn install.

Yarn then made the rest of the changes by:

  • resolving the various fsevents dependencies to version 1.2.13
  • removing resolutions for node-pre-gyp and its dependency graph
  • adding resolutions for bindings and its dependencies graph
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant