better documentation #391
Merged
better documentation #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvaughn
reviewed
Dec 15, 2019
README.md
Outdated
|
|
||
| > 1) React window improves the responsiveness of your user interface by passing only a small portion of your data to the React reconciler. | ||
| > 2) React window reduces the memory footprint of your application when displaying large datasets and prevents out of memory errors. | ||
| > 3) React window reduces the need for your web services to support a paging interface. |
There was a problem hiding this comment.
This doesn't sound quite accurate. Windowing and data fetching are kind of separate issues, and often need to both be done (using a helper lib like react-window-infinite-loader)
There was a problem hiding this comment.
It worked for us since are components were so large. But I updated the pull request and removed the last sentence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would be helpful to have a couple of sentences in the beginning better describing what it does.