Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DynamicSizeList] fix for #333 - incorrect list size due to reduction in itemCount #334

Open
wants to merge 3 commits into
base: issues/6
Choose a base branch
from
Open

[DynamicSizeList] fix for #333 - incorrect list size due to reduction in itemCount #334

wants to merge 3 commits into from

Conversation

jnishiyama
Copy link

@jnishiyama jnishiyama commented Sep 15, 2019 •
edited
Loading

Resolves Issue #333.

  • Adds check for negative return in getEstimatedTotalSize in DynamicSizeList.js.
@jnishiyama jnishiyama changed the title fix for #333 Sep 15, 2019
@daviderenger
Copy link

daviderenger commented Mar 17, 2020 •
edited
Loading

Any news on getting this in and making a new release? I want to use the dynamic list for a filter list where number of items shrink as the user types. Right now the scrollable area keeps its biggest size forever. This fix seems to the job.
@daviderenger
Copy link

daviderenger commented Mar 24, 2020 •
edited
Loading

Hi,

There is a case left where this is not working. If you have a long list, scroll down atleast one window height and then do something to lower the amount if items. In my case a text filter it stays scrolled down and the overall height is wrong.

77431171-9fd52480-6ddc-11ea-9a8d-bfd2cd410ecd

If I stay on top or close to top it works as expected.

After this happend and I scroll to top and do a new filter it never works again utnil remounting the component again.

I´ll do some digging and see if I can find what it is.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@jnishiyama @daviderenger