Version 2 [WIP]

[bvaughn]

Resolves #302

• Version 2 API
  • SimpleList (previously FixedSizeList)
  • List (previously DynamicSizeList)
  • Grid (previously VariableSizeGrid)
• Update documentation

[bvaughn]

Not sure why Flow is failing on CI but not for me locally.

[nihgwu]

Really looking forward the new components, I'm planning to switch to use List instead of Grid for the next version of BaseTable, I chose Grid instead of List to implement the BaseTable at first because the List doesn't support horizontal scrolling.

I've worked out a prototype and it's really promising, especially the change on onScroll, now I can get scrollLeft for fixed mode(horizontal scrollable) without any workaround, but there is still a limitation there, can we add an extra prop like itemWidth or innerWidth to set the inner element's width, and the default value is 100%, although I can change the style directly, but that will break the memoization.

Another concern is about the key from the itemRenderer, I think it's me suggesting you to support callback instead of using index directly, but now as we switched to renderer, I think we could just remove itemKey, and let the users to set the key for item.

[bvaughn]

Another concern is about the key from the itemRenderer, I think it's me suggesting you to support callback instead of using index directly, but now as we switched to renderer, I think we could just remove itemKey, and let the users to set the key for item.

Hm, I think we could remove the key attribute from the SimpleList renderer, and rely on users to attach it themselves. They may forget, although in that case React would warn them.

I wouldn't want to remove it from the List renderer though, since we also may want to cache other info on that same key (e.g. offset, size) in which case we'd want a stronger guarantee that the keys would never mismatch.

I think this PR is probably going to be put on hold anyway as I will probably end up trying to build more of this into react core where we can do more and more efficiently.

[nihgwu]

Then what about my first question? I understand you consideration the list should not be scrollable horizontally, but from my experience we need that feature in a lot of cases, btw I was talking about SimpleList above actually and use List for short

[bvaughn]

Lists can be horizontally scrollable if you want to make them. Overriding width style should not break your memoization. (This is true of v1 and v2.) I'd like to keep this PR discussion centered around the new API if possible.

[HenrikBechmann]

@bvaughn "Lists can be horizontally scrollable if you want to make them."

I really hope that's true! My app depends on it.

Flexbox?

[ghost]

@bvaughn Any update on this? Would v2 be released soon or I have to download this branch manually for now?