Consider floating point widths and heights of parent node #1610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delijah
force-pushed
the
floating-point-width-and-height
branch
from
a62be17
to
06f0173
Compare
|
Thinking about adding a fallback to What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases (like having a dynamic grid layout on the page) parent nodes have floating point widths and heights.
offsetWidthandoffsetHeightdoes not consider this, it just delivers integers. This results in wrong layouting.getBoundingClientRectconsiders floating point values, and therefore fixes the wrong layouting.Sidenote: According to some research i've done,
getBoundingClientRectreturns the same values forwidthandheightasoffsetWidthandoffsetHeight, except for the case when a parent node usestransform: scale(...).