Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(skywalking-logger, error-log-logger): support $hostname in skywalking service_instance_name #9401

Merged
merged 2 commits into from
May 25, 2023
Merged

fix(skywalking-logger, error-log-logger): support $hostname in skywalking service_instance_name #9401

merged 2 commits into from
May 25, 2023

Conversation

shreemaan-abhishek
Copy link
Contributor

Description

Fixes #7977

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)
@Sn0rt
Copy link
Contributor

Sn0rt commented May 9, 2023

LGTM
@monkeyDluffy6017
Copy link
Contributor

It looks like just a pick from other branch: #7252
@shreemaan-abhishek
Copy link
Contributor Author

It looks like just a pick from other branch: #7252

@monkeyDluffy6017 Oh yes, it is. But that branch wasn't merged to master so this issue still exists.
@monkeyDluffy6017 monkeyDluffy6017 changed the title fix: support $hostname in skywalking service_instance_name May 17, 2023
leslie-tsang
leslie-tsang reviewed May 17, 2023
View reviewed changes
Copy link
Member

@leslie-tsang leslie-tsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
apisix/plugins/error-log-logger.lua Show resolved Hide resolved
Sn0rt
Sn0rt previously approved these changes May 18, 2023
View reviewed changes
@monkeyDluffy6017 monkeyDluffy6017 added the wait for update wait for the author's response in this issue/PR label May 18, 2023
@monkeyDluffy6017 monkeyDluffy6017 added approved and removed wait for update wait for the author's response in this issue/PR labels May 23, 2023
@monkeyDluffy6017 monkeyDluffy6017 merged commit 212f59b into apache:master May 25, 2023
32 checks passed
@shreemaan-abhishek shreemaan-abhishek deleted the fix/logger branch May 30, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved
5 participants
@shreemaan-abhishek @Sn0rt @monkeyDluffy6017 @soulbird @leslie-tsang