fix: reduce memory usage when abnormal weights are given in chash #7103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike the planned, I choose to do the gcd in APISIX because in this way we don't need to take care of dynamically resize. Signed-off-by: spacewander <spacewanderlzx@gmail.com>
tokers
previously approved these changes
May 23, 2022
Co-authored-by: tzssangglass <tzssangglass@gmail.com>
tzssangglass
approved these changes
May 24, 2022
bzp2010
approved these changes
May 25, 2022
hongbinhsu
pushed a commit
to fitphp/apix
that referenced
this pull request
May 25, 2022
* upstream/master: test: make sure the nginx.pid is written (apache#7122) fix(grpc-transcode): pb_option should be set on the route (apache#7116) feat(ops): check dns resolver address is valid (apache#7079) fix: reduce memory usage when abnormal weights are given in chash (apache#7103)
spacewander
added a commit
to spacewander/incubator-apisix
that referenced
this pull request
Jun 20, 2022
…ache#7103) * fix: reduce memory usage when abnormal weights are given in chash Unlike the planned, I choose to do the gcd in APISIX because in this way we don't need to take care of dynamically resize. Signed-off-by: spacewander <spacewanderlzx@gmail.com> * Update apisix/core/math.lua Co-authored-by: tzssangglass <tzssangglass@gmail.com> Co-authored-by: tzssangglass <tzssangglass@gmail.com> Signed-off-by: spacewander <spacewanderlzx@gmail.com>
spacewander
added a commit
that referenced
this pull request
Jun 20, 2022
) * fix: reduce memory usage when abnormal weights are given in chash Unlike the planned, I choose to do the gcd in APISIX because in this way we don't need to take care of dynamically resize. Signed-off-by: spacewander <spacewanderlzx@gmail.com> * Update apisix/core/math.lua Co-authored-by: tzssangglass <tzssangglass@gmail.com> Co-authored-by: tzssangglass <tzssangglass@gmail.com> Signed-off-by: spacewander <spacewanderlzx@gmail.com>
spacewander
added a commit
that referenced
this pull request
Jun 30, 2022
) * fix: reduce memory usage when abnormal weights are given in chash Unlike the planned, I choose to do the gcd in APISIX because in this way we don't need to take care of dynamically resize. Signed-off-by: spacewander <spacewanderlzx@gmail.com> * Update apisix/core/math.lua Co-authored-by: tzssangglass <tzssangglass@gmail.com> Co-authored-by: tzssangglass <tzssangglass@gmail.com>
Liu-Junlin
pushed a commit
to Liu-Junlin/apisix
that referenced
this pull request
Nov 4, 2022
…ache#7103) * fix: reduce memory usage when abnormal weights are given in chash Unlike the planned, I choose to do the gcd in APISIX because in this way we don't need to take care of dynamically resize. Signed-off-by: spacewander <spacewanderlzx@gmail.com> * Update apisix/core/math.lua Co-authored-by: tzssangglass <tzssangglass@gmail.com> Co-authored-by: tzssangglass <tzssangglass@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike the planned, I choose to do the gcd in APISIX because in this way
we don't need to take care of dynamically resizing.
Signed-off-by: spacewander spacewanderlzx@gmail.com
Description
Fixes #7042
Checklist