fix(authz-keycloak): do not expose internal errors to the client #6854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacewander
reviewed
Apr 15, 2022
| @@ -722,12 +722,12 @@ local function generate_token_using_password_grant(conf,ctx) | |||
| if not username then | |||
| local err = "username is missing." | |||
| log.error(err) | |||
| return 422, err | |||
| return 422, {message = err} | |||
There was a problem hiding this comment.
Would be better to add test to cover this branch?
| end | ||
| if not password then | ||
| local err = "password is missing." | ||
| log.error(err) | ||
| return 422, err | ||
| return 422, {message = err} |
apisix/plugins/authz-keycloak.lua
Outdated
| @@ -722,12 +722,12 @@ local function generate_token_using_password_grant(conf,ctx) | |||
| if not username then | |||
| local err = "username is missing." | |||
| log.error(err) | |||
| return 422, err | |||
| return 422, {message = err} | |||
| end | |||
| if not password then | |||
| local err = "password is missing." | |||
| log.error(err) | |||
There was a problem hiding this comment.
Shall we use log level warn instead of error level with 4xx status code ?
spacewander
reviewed
Apr 17, 2022
t/plugin/authz-keycloak.t
Outdated
|
|
||
|
|
||
|
|
||
| === TEST 19: no username of password |
There was a problem hiding this comment.
Suggested change
| === TEST 19: no username of password | |
| === TEST 19: no username or password |
spacewander
approved these changes
Apr 17, 2022
leslie-tsang
approved these changes
Apr 17, 2022
5 tasks
Liu-Junlin
pushed a commit
to Liu-Junlin/apisix
that referenced
this pull request
May 20, 2022
spacewander
pushed a commit
that referenced
this pull request
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
Checklist