Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change: remove deprecated upstream.enable_websocket #3854

Merged
merged 1 commit into from
Mar 19, 2021
Merged

change: remove deprecated upstream.enable_websocket #3854

merged 1 commit into from
Mar 19, 2021

Conversation

spacewander
Copy link
Member

Signed-off-by: spacewander spacewanderlzx@gmail.com

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
@spacewander
change: remove deprecated upstream.enable_websocket
c8e6fbb 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander marked this pull request as ready for review March 18, 2021 03:08
@Firstsawyou
Copy link
Contributor

LGTM.
imjoey
imjoey approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@imjoey imjoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
@tokers
Copy link
Contributor

tokers commented Mar 18, 2021

@spacewander The document also should be updated.
@spacewander
Copy link
Member Author

The doc has been updated before.
@tokers tokers merged commit f3a6c2a into apache:master Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants
@spacewander @Firstsawyou @tokers @imjoey