Change display name each flavor on debug #1541
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I5023bab448ae1ac2de74333fd8758a7b0c3c873d
Change-Id: Ia1b6e921a164636aa2b8076af40fa61780cfe0cc
Change-Id: Idc76aba336e5f15bd3cdd808651b190e5992d82c
Change-Id: If99be35af19eddf6a918c00d47ba3ca60139a04b
Change-Id: Icb5455a4887cc8cab9e6ebcc6ad4751343238cc6
Change-Id: Ia3dbd7e805ad02c00fe24fbe0e06a9fb3fdf3976
| @@ -37,7 +37,6 @@ kotlin.code.style=official | |||
|
|
|||
| # Disable build features that are enabled by default, | |||
| # https://developer.android.com/build/releases/gradle-plugin#default-changes | |||
| android.defaults.buildfeatures.resvalues=false | |||
There was a problem hiding this comment.
IMO re-enabling resValues for that is not good. We already have specific sourceSet for all flavors.
Also, I'm not sure that Prod variant is actually expected to be installed by regular devs, since it needs production keys etc.
This makes the actual Demo app name appearance worse.
There was a problem hiding this comment.
@SimonMarquis
It seems hard it to do with resValue from the error logs. I can do same thing with another way without resValues.
Before refactor that, I also wonder prod usage, this project just needs the prodRelease?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I have done and why
prodDebug and demoDebug is hardly distinguish each app on the screen.
I changed the app name based on the flavor on
debug, exceptrelease.Now, we can distinguish both at once glance on the screen.