Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] support DynamicNFT #2726

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[DO NOT MERGE] support DynamicNFT #2726

wants to merge 7 commits into from

Conversation

yinyiqian1
Copy link

@yinyiqian1 yinyiqian1 commented Jul 4, 2024 •
edited
Loading

support DynamicNFT XRPLF/rippled#5048

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Did you update HISTORY.md?

  • Yes
  • [] No, this change does not impact library users

Test Plan
@yinyiqian1 yinyiqian1 marked this pull request as draft July 4, 2024 18:28
@yinyiqian1 yinyiqian1 marked this pull request as ready for review July 4, 2024 18:43
@mvadari
Copy link
Collaborator

mvadari commented Jul 5, 2024 •
edited
Loading

FYI the general policy with this repo and xrpl-py is that amendment PRs aren't merged until the corresponding rippled PR is merged (though of course development can happen before).
shawnxie999
shawnxie999 approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@shawnxie999 shawnxie999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a nit, but looks good! (should not be merged till rippled changes are merged)
@mvadari mvadari changed the title support DynamicNFT Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants
@yinyiqian1 @mvadari @shawnxie999 @xVet