Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translation should depend on number of items #62857

Merged
merged 1 commit into from
Jun 26, 2024
Merged

translation should depend on number of items #62857

merged 1 commit into from
Jun 26, 2024

Conversation

iworks
Copy link
Contributor

@iworks iworks commented Jun 26, 2024 •
edited
Loading

What?

The translation string should be depend on number of items.

Why?

How?

I added only a string for single item.

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: iworks <iworks@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: ellatrix <ellatrix@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jun 26, 2024
@github-actions GitHub Actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @iworks! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.
@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended Internationalization (i18n) Issues or PRs related to internationalization efforts [Package] Editor /packages/editor [Type] Enhancement A suggestion for improvement. and removed [Type] Bug An existing feature does not function as intended [Type] Enhancement A suggestion for improvement. labels Jun 26, 2024
Mamaduka
Mamaduka approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, @iworks!
@Mamaduka
Copy link
Member

@ellatrix, @vcanales, I'm flagging this for the next RC. This is a new string, and a fix for it can probably go even after "string freeze."
@Mamaduka Mamaduka added the Backport to WP 6.6 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jun 26, 2024
@ellatrix
Copy link
Member

We're in hard string freeze though. I can ask about it.
@Mamaduka Mamaduka merged commit 3f0c4e0 into WordPress:trunk Jun 26, 2024
78 of 79 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.8 milestone Jun 26, 2024
@ellatrix ellatrix mentioned this pull request Jun 27, 2024
Merged
ellatrix added a commit that referenced this pull request Jul 2, 2024
@iworks @Mamaduka @ellatrix
Editor: Translation should depend on number of items (#62857)
3503fc2 
Co-authored-by: iworks <iworks@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
@ellatrix ellatrix mentioned this pull request Jul 2, 2024
Merged
ellatrix added a commit that referenced this pull request Jul 2, 2024
@iworks @Mamaduka @ellatrix
Editor: Translation should depend on number of items (#62857)
35de0f6 
Co-authored-by: iworks <iworks@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
@ellatrix
Copy link
Member

ellatrix commented Jul 2, 2024

Backported with #63038
@ellatrix ellatrix added Backported to WP Core Pull request that has been successfully merged into WP Core and removed Backport to WP 6.6 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta labels Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported to WP Core Pull request that has been successfully merged into WP Core First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository Internationalization (i18n) Issues or PRs related to internationalization efforts [Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended
3 participants
@iworks @Mamaduka @ellatrix