Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use distributed Nx agents for e2e tests #1911

Closed
wants to merge 6 commits into from
Closed

Conversation

lachlancollins
Copy link
Member

@lachlancollins lachlancollins commented Jul 7, 2024

This changes the "test:e2e" tasks to run on the distributed Nx agents, rather than on its own GitHub job. This means the tasks are cached and parallelised optimally.

Unfortunately, this isn't compatible with the "@replayio/playwright" setup (it uses the standard "@playwright/test" setup), but I'm not sure how much this was being used - if this is a necessary part of the workflow, then this change won't work.

Copy link

nx-cloud bot commented Jul 7, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1b83944. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Jul 7, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: 1b83944

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@1911

@tanstack/react-cross-context

npm i https://pkg.pr.new/@tanstack/react-cross-context@1911

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@1911

@tanstack/react-router-with-query

npm i https://pkg.pr.new/@tanstack/react-router-with-query@1911

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@1911

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@1911

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@1911

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@1911

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@1911

@tanstack/start

npm i https://pkg.pr.new/@tanstack/start@1911

@tanstack/start-vite-plugin

npm i https://pkg.pr.new/@tanstack/start-vite-plugin@1911


templates

@lachlancollins lachlancollins changed the title WIP: Try using Nx for playwright tests Jul 7, 2024
@lachlancollins lachlancollins marked this pull request as ready for review July 7, 2024 01:35
Copy link
Contributor

@SeanCassiere SeanCassiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, it's a good sanity check to make sure the Start examples (start-basic and start-basic-react-query), still work correctly after changes have been made to any of our packages. In the future, we should probably expand it to crawl our kitchen-sink or quickstart examples as well.

The replay.io is quite useful for actually watching the playback of what happened during the tests (especially in the failed cases).

@lachlancollins from what I can gather, this run only failed because an API key was missing. Could the job, not inherit the API key from the workflow?

Also, @jasonLaster @callingmedic911, could you please reconfirm that having this particular API key being publicly viewable is OK? And do we need different API keys for each example project? Currently, on the replay dashboard I'm only seeing the tests being recorded for start-basic but not the ones for start-basic-react-query.
image
image

@SeanCassiere
Copy link
Contributor

Closing for now

@lachlancollins lachlancollins deleted the unify-e2e branch July 19, 2024 09:35
@jasonLaster
Copy link
Contributor

@SeanCassiere Yes - it's fine for the API key to be publicly available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants