@W-16161754 - [BUG 🐞] Fix useCustomQuery
not using throwOnBadResponse
argument
#1879
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We recently added the
useCustomQuery
hook to thecommerce-sdk-react
library. But we forgot to ensure that we are passing thethrowOnBadResponse=true
argument. This meant that custom apis that were returning error status codes weren't throwing errors resulting in the hooks query status being a "success" when it should be an "error". This PR fixes this by passing this argument in.Types of Changes
Changes
throwOnBadResponse=true
to isomorphic helper inuseCustomQuery
How to Test-Drive This PR
test-commerce-sdk-react
project and gotohttp://localhost:3000/custom-endpoint
pages/use-custom-endpoint.tsx
to beapiName: 'hello-world-bad'
Checklists
General