Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: re-implement skipped cart page unit tests @W-15110504@ #1871

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

joeluong-sfcc
Copy link
Collaborator

Description

This PR adds back in tests that were skipped due to some updates that broke those tests. There is still a unit test being skipped, remove from cart test, but I couldn't find a good way to make it pass as it consistently timed out for me.

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

  1. git checkout ju/fix-cart-tests
  2. cd packages/template-retail-react-app
  3. npm run test 'app/pages/cart/index.test.js --coverage=false'
  4. Observe that the unit test passes and there is only 1 skipped test (remove from cart test)

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)
@joeluong-sfcc joeluong-sfcc requested a review from a team as a code owner July 2, 2024 15:08
@joeluong-sfcc joeluong-sfcc marked this pull request as draft July 2, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant