Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default node version to 20.x #1867

Merged
merged 4 commits into from
Jun 26, 2024
Merged

change default node version to 20.x #1867

merged 4 commits into from
Jun 26, 2024

Conversation

kevinxh
Copy link
Collaborator

@kevinxh kevinxh commented Jun 26, 2024

Description

This PR changes the default node.js version from 18.x to 20.x

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

  • (step1)

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)
@kevinxh kevinxh requested a review from a team as a code owner June 26, 2024 16:07
adamraya
adamraya previously approved these changes Jun 26, 2024
Copy link
Collaborator

@adamraya adamraya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to update the default Node version in GA as well.

IS_MRT_NODE: ${{ matrix.node == 18 && matrix.npm == 10 }}

@adamraya
Copy link
Collaborator

We may want to update the default Node version in GA as well.

IS_MRT_NODE: ${{ matrix.node == 18 && matrix.npm == 10 }}

and here:

IS_MRT_NODE: ${{ matrix.node == 18 && matrix.npm == 10 }}

vcua-mobify
vcua-mobify previously approved these changes Jun 26, 2024
Copy link
Contributor

@vcua-mobify vcua-mobify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @adamraya that we probably want to upgrade the CI's IS_MRT_NODE property to Node 20 since our docs also recommend Node 20: https://developer.salesforce.com/docs/commerce/pwa-kit-managed-runtime/guide/upgrade-node-version.html

@kevinxh kevinxh dismissed stale reviews from vcua-mobify and adamraya via 3a387b4 June 26, 2024 17:55
@kevinxh kevinxh merged commit 03bac4a into develop Jun 26, 2024
28 checks passed
@kevinxh kevinxh deleted the default-node-20x branch June 26, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants