-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change default node version to 20.x #1867
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to update the default Node version in GA as well.
pwa-kit/.github/workflows/test.yml
Line 144 in 5609322
IS_MRT_NODE: ${{ matrix.node == 18 && matrix.npm == 10 }} |
and here: pwa-kit/.github/workflows/test.yml Line 49 in 5609322
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @adamraya that we probably want to upgrade the CI's IS_MRT_NODE property to Node 20 since our docs also recommend Node 20: https://developer.salesforce.com/docs/commerce/pwa-kit-managed-runtime/guide/upgrade-node-version.html
Description
This PR changes the default node.js version from 18.x to 20.x
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization