Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACTION] New action create-custom-field-options-context #12629

Merged
merged 1 commit into from
Jul 23, 2024
Merged

[ACTION] New action create-custom-field-options-context #12629

merged 1 commit into from
Jul 23, 2024

Conversation

jcortes
Copy link
Collaborator

@jcortes jcortes commented Jun 27, 2024 •
edited by coderabbitai bot
Loading

WHY

Resolves #12528

Summary by CodeRabbit

  • Chores
    • Updated versioning for multiple Jira components, ensuring all actions and sources reflect the latest versions for optimal performance and compatibility.
    • Added a new constant for limiting results to enhance API efficiency.
@jcortes jcortes added the action New Action Request label Jun 27, 2024
@jcortes jcortes self-assigned this Jun 27, 2024
@vercel Vercel
Copy link

vercel bot commented Jun 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
pipedream-docs-redirect-do-not-edit ⬜️ Ignored (Inspect) Jul 22, 2024 4:38pm
@vercel Vercel
Copy link

vercel bot commented Jun 27, 2024

@jcortes is attempting to deploy a commit to the Pipedreamers Team on Vercel.

A member of the Team first needs to authorize it.
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 27, 2024 •
edited
Loading

Walkthrough

The changes consist of version updates for multiple Jira actions and components. Most actions have been incremented by one version number, indicating improvements or enhancements. Notable updates include the introduction of new functionality for creating custom field options, while existing actions received minor documentation improvements. This release aims to enhance integration with Jira's API.

Changes

Files Change Summary
components/jira/actions/add-attachment-to-issue/... Updated version from "0.2.10" to "0.2.11".
components/jira/actions/add-comment-to-issue/... Updated version from "0.1.8" to "0.1.9".
components/jira/actions/add-multiple-attachments-to-issue/... Updated version from "0.0.8" to "0.0.9".
components/jira/actions/add-watcher-to-issue/... Updated version from "0.0.7" to "0.0.8".
components/jira/actions/assign-issue/... Updated version from "0.0.7" to "0.0.8".
components/jira/actions/create-custom-field-options-context/... Introduced action for creating a context for custom fields.
components/jira/actions/create-issue/... Updated version from "0.1.16" to "0.1.17".
components/jira/actions/create-version/... Updated version from "0.1.8" to "0.1.9".
components/jira/actions/delete-project/... Updated version from "0.1.8" to "0.1.9".
components/jira/actions/get-all-projects/... Updated version from "0.1.9" to "0.1.10".
components/jira/actions/get-issue/... Updated version from "0.1.10" to "0.1.11".
components/jira/actions/get-task/... Updated version from "0.1.8" to "0.1.9".
components/jira/actions/get-transitions/... Updated version from "0.1.8" to "0.1.9".
components/jira/actions/get-user/... Updated version from "0.1.8" to "0.1.9".
components/jira/actions/get-users/... Updated version from "0.0.3" to "0.0.4".
components/jira/actions/list-issue-comments/... Updated version from "0.1.8" to "0.1.9".
components/jira/actions/transition-issue/... Updated version from "0.1.10" to "0.1.11".
components/jira/actions/update-comment/... Updated version from "0.1.8" to "0.1.9".
components/jira/actions/update-issue/... Updated version from "0.2.10" to "0.2.11".
components/jira/common/constants.mjs Added new constant DEFAULT_LIMIT with value 50.
components/jira/common/utils.mjs Added parseArray method and import of ConfigurationError.
components/jira/jira.app.mjs Added import for constants and new properties/methods.
components/jira/package.json Updated version from "0.0.16" to "0.1.0".
components/jira/sources/events/... Updated version from "0.0.8" to "0.0.9".
components/jira/sources/issue-created/... Updated version from "0.0.8" to "0.0.9".
components/jira/sources/issue-deleted/... Updated version from "0.0.8" to "0.0.9".
components/jira/sources/issue-updated/... Updated version from "0.0.8" to "0.0.9".

Sequence Diagram(s)

(Diagrams were not generated as the changes are primarily version updates with no significant alterations to control flow.)

Assessment against linked issues

Objective Addressed Explanation
Ability to update values for custom fields in project (#12528) ❌ The current changes do not implement the ability to update project-level custom fields.

Poem

🐇
In the world of Jira, we dance and we play,
With each version updated, we hop on our way.
New fields to create, and actions refined,
With each little change, more joy we find! 🌟
🐰

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
coderabbitai[bot]
coderabbitai bot reviewed Jun 27, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 79efd66 and 63a0be7.

Files selected for processing (5)
  • components/jira/actions/create-custom-field-options-context/create-custom-field-options-context.mjs (1 hunks)
  • components/jira/common/constants.mjs (1 hunks)
  • components/jira/common/utils.mjs (2 hunks)
  • components/jira/jira.app.mjs (3 hunks)
  • components/jira/package.json (1 hunks)
Files skipped from review due to trivial changes (2)
  • components/jira/common/constants.mjs
  • components/jira/package.json
Additional comments not posted (6)
components/jira/common/utils.mjs (2)

1-1: Import of ConfigurationError approved.

This import enhances error handling by allowing more specific error messages, improving the robustness of the application.

25-46: New function parseArray is well-implemented.

This function correctly handles different types of input and ensures that only valid array data is processed. It enhances data integrity and error handling by using ConfigurationError to provide clear feedback on input errors.

components/jira/actions/create-custom-field-options-context/create-custom-field-options-context.mjs (1)

4-83: New action Create Custom Field Options (Context) is correctly implemented.

The action is well-defined with clear properties and methods. The use of utility functions for data parsing within the run method ensures robust data handling. This aligns with the objectives of the PR and enhances the Jira component's functionality.

components/jira/jira.app.mjs (3)

4-4: Import of constants approved.

Using shared constants enhances maintainability and reduces potential errors in the application. This is a positive change.

572-577: New method getFieldsPaginated is well-implemented.

This method efficiently handles the pagination of field data, using the DEFAULT_LIMIT constant to control the page size. This is crucial for performance and scalability.

578-585: New method getCustomFieldContexts is correctly implemented.

Like getFieldsPaginated, this method provides a consistent and efficient way to fetch custom field contexts with pagination, enhancing the module's functionality and performance.
@jcortes jcortes force-pushed the jira-custom-field-options-context branch from 63a0be7 to e5bf878 Compare June 28, 2024 15:17
coderabbitai[bot]
coderabbitai bot reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 63a0be7 and e5bf878.

Files selected for processing (27)
  • components/jira/actions/add-attachment-to-issue/add-attachment-to-issue.mjs (1 hunks)
  • components/jira/actions/add-comment-to-issue/add-comment-to-issue.mjs (1 hunks)
  • components/jira/actions/add-multiple-attachments-to-issue/add-multiple-attachments-to-issue.mjs (1 hunks)
  • components/jira/actions/add-watcher-to-issue/add-watcher-to-issue.mjs (1 hunks)
  • components/jira/actions/assign-issue/assign-issue.mjs (1 hunks)
  • components/jira/actions/create-custom-field-options-context/create-custom-field-options-context.mjs (1 hunks)
  • components/jira/actions/create-issue/create-issue.mjs (1 hunks)
  • components/jira/actions/create-version/create-version.mjs (1 hunks)
  • components/jira/actions/delete-project/delete-project.mjs (1 hunks)
  • components/jira/actions/get-all-projects/get-all-projects.mjs (1 hunks)
  • components/jira/actions/get-issue/get-issue.mjs (1 hunks)
  • components/jira/actions/get-task/get-task.mjs (1 hunks)
  • components/jira/actions/get-transitions/get-transitions.mjs (1 hunks)
  • components/jira/actions/get-user/get-user.mjs (1 hunks)
  • components/jira/actions/get-users/get-users.mjs (1 hunks)
  • components/jira/actions/list-issue-comments/list-issue-comments.mjs (1 hunks)
  • components/jira/actions/transition-issue/transition-issue.mjs (1 hunks)
  • components/jira/actions/update-comment/update-comment.mjs (1 hunks)
  • components/jira/actions/update-issue/update-issue.mjs (1 hunks)
  • components/jira/common/constants.mjs (1 hunks)
  • components/jira/common/utils.mjs (2 hunks)
  • components/jira/jira.app.mjs (3 hunks)
  • components/jira/package.json (1 hunks)
  • components/jira/sources/events/events.mjs (1 hunks)
  • components/jira/sources/issue-created/issue-created.mjs (1 hunks)
  • components/jira/sources/issue-deleted/issue-deleted.mjs (1 hunks)
  • components/jira/sources/issue-updated/issue-updated.mjs (1 hunks)
Files skipped from review due to trivial changes (22)
  • components/jira/actions/add-attachment-to-issue/add-attachment-to-issue.mjs
  • components/jira/actions/add-comment-to-issue/add-comment-to-issue.mjs
  • components/jira/actions/add-multiple-attachments-to-issue/add-multiple-attachments-to-issue.mjs
  • components/jira/actions/add-watcher-to-issue/add-watcher-to-issue.mjs
  • components/jira/actions/assign-issue/assign-issue.mjs
  • components/jira/actions/create-issue/create-issue.mjs
  • components/jira/actions/create-version/create-version.mjs
  • components/jira/actions/delete-project/delete-project.mjs
  • components/jira/actions/get-all-projects/get-all-projects.mjs
  • components/jira/actions/get-issue/get-issue.mjs
  • components/jira/actions/get-task/get-task.mjs
  • components/jira/actions/get-transitions/get-transitions.mjs
  • components/jira/actions/get-user/get-user.mjs
  • components/jira/actions/get-users/get-users.mjs
  • components/jira/actions/list-issue-comments/list-issue-comments.mjs
  • components/jira/actions/transition-issue/transition-issue.mjs
  • components/jira/actions/update-comment/update-comment.mjs
  • components/jira/actions/update-issue/update-issue.mjs
  • components/jira/sources/events/events.mjs
  • components/jira/sources/issue-created/issue-created.mjs
  • components/jira/sources/issue-deleted/issue-deleted.mjs
  • components/jira/sources/issue-updated/issue-updated.mjs
Files skipped from review as they are similar to previous changes (5)
  • components/jira/actions/create-custom-field-options-context/create-custom-field-options-context.mjs
  • components/jira/common/constants.mjs
  • components/jira/common/utils.mjs
  • components/jira/jira.app.mjs
  • components/jira/package.json
@jcortes jcortes force-pushed the jira-custom-field-options-context branch from e5bf878 to c40659b Compare July 17, 2024 22:43
coderabbitai[bot]
coderabbitai bot reviewed Jul 17, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e5bf878 and c40659b.

Files selected for processing (1)
  • components/jira/actions/add-attachment-to-issue/add-attachment-to-issue.mjs (1 hunks)
Files skipped from review due to trivial changes (1)
  • components/jira/actions/add-attachment-to-issue/add-attachment-to-issue.mjs
@jcortes jcortes force-pushed the jira-custom-field-options-context branch from c40659b to 91406aa Compare July 18, 2024 21:10
coderabbitai[bot]
coderabbitai bot reviewed Jul 18, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c40659b and 91406aa.

Files selected for processing (27)
  • components/jira/actions/add-attachment-to-issue/add-attachment-to-issue.mjs (1 hunks)
  • components/jira/actions/add-comment-to-issue/add-comment-to-issue.mjs (1 hunks)
  • components/jira/actions/add-multiple-attachments-to-issue/add-multiple-attachments-to-issue.mjs (1 hunks)
  • components/jira/actions/add-watcher-to-issue/add-watcher-to-issue.mjs (1 hunks)
  • components/jira/actions/assign-issue/assign-issue.mjs (1 hunks)
  • components/jira/actions/create-custom-field-options-context/create-custom-field-options-context.mjs (1 hunks)
  • components/jira/actions/create-issue/create-issue.mjs (1 hunks)
  • components/jira/actions/create-version/create-version.mjs (1 hunks)
  • components/jira/actions/delete-project/delete-project.mjs (1 hunks)
  • components/jira/actions/get-all-projects/get-all-projects.mjs (1 hunks)
  • components/jira/actions/get-issue/get-issue.mjs (1 hunks)
  • components/jira/actions/get-task/get-task.mjs (1 hunks)
  • components/jira/actions/get-transitions/get-transitions.mjs (1 hunks)
  • components/jira/actions/get-user/get-user.mjs (1 hunks)
  • components/jira/actions/get-users/get-users.mjs (1 hunks)
  • components/jira/actions/list-issue-comments/list-issue-comments.mjs (1 hunks)
  • components/jira/actions/transition-issue/transition-issue.mjs (1 hunks)
  • components/jira/actions/update-comment/update-comment.mjs (1 hunks)
  • components/jira/actions/update-issue/update-issue.mjs (1 hunks)
  • components/jira/common/constants.mjs (1 hunks)
  • components/jira/common/utils.mjs (2 hunks)
  • components/jira/jira.app.mjs (3 hunks)
  • components/jira/package.json (1 hunks)
  • components/jira/sources/events/events.mjs (1 hunks)
  • components/jira/sources/issue-created/issue-created.mjs (1 hunks)
  • components/jira/sources/issue-deleted/issue-deleted.mjs (1 hunks)
  • components/jira/sources/issue-updated/issue-updated.mjs (1 hunks)
Files skipped from review due to trivial changes (6)
  • components/jira/actions/assign-issue/assign-issue.mjs
  • components/jira/actions/get-all-projects/get-all-projects.mjs
  • components/jira/actions/get-user/get-user.mjs
  • components/jira/actions/update-comment/update-comment.mjs
  • components/jira/package.json
  • components/jira/sources/issue-created/issue-created.mjs
Files skipped from review as they are similar to previous changes (1)
  • components/jira/actions/add-attachment-to-issue/add-attachment-to-issue.mjs
Additional comments not posted (31)
components/jira/sources/issue-deleted/issue-deleted.mjs (1)

7-7: Version update is correct.

The version has been updated from "0.0.8" to "0.0.9". Ensure that the version update is consistent across the codebase.

components/jira/sources/issue-updated/issue-updated.mjs (1)

7-7: Version update is correct.

The version has been updated from "0.0.8" to "0.0.9". Ensure that the version update is consistent across the codebase.

components/jira/common/constants.mjs (1)

37-37: New constant DEFAULT_LIMIT added.

The constant DEFAULT_LIMIT with a value of 50 has been added. Ensure that this constant is used appropriately in the codebase.

components/jira/sources/events/events.mjs (1)

8-8: Version update is correct.

The version has been updated from "0.0.8" to "0.0.9". Ensure that the version update is consistent across the codebase.

components/jira/actions/get-users/get-users.mjs (1)

7-7: LGTM! Version update approved.

The version update from "0.0.3" to "0.0.4" is approved. No other issues found.

components/jira/actions/get-task/get-task.mjs (1)

7-7: LGTM! Version update approved.

The version update from "0.1.8" to "0.1.9" is approved. No other issues found.

components/jira/actions/delete-project/delete-project.mjs (1)

7-7: LGTM! Version update approved.

The version update from "0.1.8" to "0.1.9" is approved. No other issues found.

components/jira/actions/add-watcher-to-issue/add-watcher-to-issue.mjs (1)

6-6: LGTM! Version update approved.

The version update from "0.0.7" to "0.0.8" is approved. No other issues found.

components/jira/actions/list-issue-comments/list-issue-comments.mjs (1)

7-7: Version update approved.

The version update from "0.1.8" to "0.1.9" is consistent with the intended release or update.

components/jira/common/utils.mjs (2)

1-1: Import statement approved.

The import of ConfigurationError from @pipedream/platform is necessary for error handling in the parseArray function.

25-45: Function implementation approved.

The parseArray function is well-implemented with proper error handling, ensuring that invalid array objects are handled gracefully.

components/jira/actions/create-custom-field-options-context/create-custom-field-options-context.mjs (5)

1-2: Import statements approved.

The imports of app from ../../jira.app.mjs and utils from ../../common/utils.mjs are necessary for the functionality of the action.

5-9: Object export approved.

The object export is well-structured and includes all necessary components for the action.

10-48: Props approved.

The props are well-defined and necessary for the action, with accurate descriptions and types.

50-59: Method implementation approved.

The createCustomFieldOptionsContext method is well-implemented and necessary for creating custom field options context.

61-82: Run function implementation approved.

The run function is well-implemented with proper error handling and response management.

components/jira/actions/add-multiple-attachments-to-issue/add-multiple-attachments-to-issue.mjs (1)

11-11: Version update approved.

The version update from "0.0.8" to "0.0.9" is consistent with the intended release or update.

components/jira/actions/add-comment-to-issue/add-comment-to-issue.mjs (2)

8-8: Version update approved.

The version has been updated from "0.1.8" to "0.1.9". This change is minor and likely includes bug fixes or small enhancements.

Line range hint 34-52:
Function implementation approved.

The run function is correctly implemented, with proper parsing of input properties and handling of the API call to add a comment to a Jira issue.

components/jira/actions/get-transitions/get-transitions.mjs (2)

7-7: Version update approved.

The version has been updated from "0.1.8" to "0.1.9". This change is minor and likely includes bug fixes or small enhancements.

Line range hint 34-43:
Function implementation approved.

The run function is correctly implemented, with proper handling of input properties and the API call to retrieve transitions for a Jira issue.

components/jira/actions/transition-issue/transition-issue.mjs (2)

8-8: Version update approved.

The version has been updated from "0.1.10" to "0.1.11". This change is minor and likely includes bug fixes or small enhancements.

Line range hint 34-52:
Function implementation approved.

The run function is correctly implemented, with proper parsing of input properties and handling of the API call to perform a transition for a Jira issue.

components/jira/actions/create-issue/create-issue.mjs (2)

10-10: Version update approved.

The version has been updated from "0.1.16" to "0.1.17". This change is minor and likely includes bug fixes or small enhancements.

Line range hint 34-64:
Function implementation approved.

The run function is correctly implemented, with proper parsing of input properties and handling of the API call to create a Jira issue.

components/jira/actions/create-version/create-version.mjs (1)

7-7: Version update confirmed.

The version number has been updated from "0.1.8" to "0.1.9". No other changes are introduced in this file.

components/jira/actions/get-issue/get-issue.mjs (1)

7-7: Version update confirmed.

The version number has been updated from "0.1.10" to "0.1.11". No other changes are introduced in this file.

components/jira/actions/update-issue/update-issue.mjs (1)

11-11: Version update confirmed.

The version number has been updated from "0.2.10" to "0.2.11". No other changes are introduced in this file.

components/jira/jira.app.mjs (3)

4-4: New import statement added.

The import statement for constants from ./common/constants.mjs has been added. Ensure this module is correctly implemented and used.

217-311: New properties and methods added.

The properties fieldId and contextId have been added with their respective options methods. Ensure these properties and methods are correctly implemented and follow best practices.

572-585: New methods added.

The methods getFieldsPaginated and getCustomFieldContexts have been added for API requests. Ensure these methods are correctly implemented and follow best practices.
GTFalcao
GTFalcao previously approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@GTFalcao GTFalcao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@jcortes
New action component create-custom-field-options-context
b85f3cd 
Added docs link

Fixed path

Fixed parsing
@jcortes jcortes force-pushed the jira-custom-field-options-context branch from 91406aa to b85f3cd Compare July 22, 2024 16:38
coderabbitai[bot]
coderabbitai bot reviewed Jul 22, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 91406aa and b85f3cd.

Files selected for processing (27)
  • components/jira/actions/add-attachment-to-issue/add-attachment-to-issue.mjs (1 hunks)
  • components/jira/actions/add-comment-to-issue/add-comment-to-issue.mjs (1 hunks)
  • components/jira/actions/add-multiple-attachments-to-issue/add-multiple-attachments-to-issue.mjs (1 hunks)
  • components/jira/actions/add-watcher-to-issue/add-watcher-to-issue.mjs (1 hunks)
  • components/jira/actions/assign-issue/assign-issue.mjs (1 hunks)
  • components/jira/actions/create-custom-field-options-context/create-custom-field-options-context.mjs (1 hunks)
  • components/jira/actions/create-issue/create-issue.mjs (1 hunks)
  • components/jira/actions/create-version/create-version.mjs (1 hunks)
  • components/jira/actions/delete-project/delete-project.mjs (1 hunks)
  • components/jira/actions/get-all-projects/get-all-projects.mjs (1 hunks)
  • components/jira/actions/get-issue/get-issue.mjs (1 hunks)
  • components/jira/actions/get-task/get-task.mjs (1 hunks)
  • components/jira/actions/get-transitions/get-transitions.mjs (1 hunks)
  • components/jira/actions/get-user/get-user.mjs (1 hunks)
  • components/jira/actions/get-users/get-users.mjs (1 hunks)
  • components/jira/actions/list-issue-comments/list-issue-comments.mjs (1 hunks)
  • components/jira/actions/transition-issue/transition-issue.mjs (1 hunks)
  • components/jira/actions/update-comment/update-comment.mjs (1 hunks)
  • components/jira/actions/update-issue/update-issue.mjs (1 hunks)
  • components/jira/common/constants.mjs (1 hunks)
  • components/jira/common/utils.mjs (2 hunks)
  • components/jira/jira.app.mjs (3 hunks)
  • components/jira/package.json (1 hunks)
  • components/jira/sources/events/events.mjs (1 hunks)
  • components/jira/sources/issue-created/issue-created.mjs (1 hunks)
  • components/jira/sources/issue-deleted/issue-deleted.mjs (1 hunks)
  • components/jira/sources/issue-updated/issue-updated.mjs (1 hunks)
Files skipped from review due to trivial changes (7)
  • components/jira/actions/add-comment-to-issue/add-comment-to-issue.mjs
  • components/jira/actions/add-watcher-to-issue/add-watcher-to-issue.mjs
  • components/jira/actions/assign-issue/assign-issue.mjs
  • components/jira/actions/create-issue/create-issue.mjs
  • components/jira/actions/get-transitions/get-transitions.mjs
  • components/jira/actions/transition-issue/transition-issue.mjs
  • components/jira/common/constants.mjs
Files skipped from review as they are similar to previous changes (19)
  • components/jira/actions/add-attachment-to-issue/add-attachment-to-issue.mjs
  • components/jira/actions/add-multiple-attachments-to-issue/add-multiple-attachments-to-issue.mjs
  • components/jira/actions/create-version/create-version.mjs
  • components/jira/actions/delete-project/delete-project.mjs
  • components/jira/actions/get-all-projects/get-all-projects.mjs
  • components/jira/actions/get-issue/get-issue.mjs
  • components/jira/actions/get-task/get-task.mjs
  • components/jira/actions/get-user/get-user.mjs
  • components/jira/actions/get-users/get-users.mjs
  • components/jira/actions/list-issue-comments/list-issue-comments.mjs
  • components/jira/actions/update-comment/update-comment.mjs
  • components/jira/actions/update-issue/update-issue.mjs
  • components/jira/common/utils.mjs
  • components/jira/jira.app.mjs
  • components/jira/package.json
  • components/jira/sources/events/events.mjs
  • components/jira/sources/issue-created/issue-created.mjs
  • components/jira/sources/issue-deleted/issue-deleted.mjs
  • components/jira/sources/issue-updated/issue-updated.mjs
Additional comments not posted (9)
components/jira/actions/create-custom-field-options-context/create-custom-field-options-context.mjs (9)

1-2: LGTM! Imports are appropriate and necessary.

The imports from ../../jira.app.mjs and ../../common/utils.mjs are essential for the action's functionality.

4-9: LGTM! Metadata is well-defined.

The metadata provides a clear and concise description of the action.

10-11: LGTM! app prop is necessary.

The app prop is essential for the action to interact with Jira.

12-17: LGTM! cloudId prop is necessary.

The cloudId prop is essential for identifying the Jira cloud instance.

18-31: LGTM! fieldId prop is necessary.

The fieldId prop is essential for identifying the custom field in Jira.

32-43: LGTM! contextId prop is necessary.

The contextId prop is essential for identifying the context for the custom field options.

44-48: LGTM! options prop is necessary.

The options prop is essential for specifying the custom field options to be created.

50-59: LGTM! createCustomFieldOptionsContext method is well-defined.

The method is essential for making the API request to create custom field options context.

61-82: LGTM! The run function is well-structured.

The function handles the action's execution flow appropriately and ensures proper parsing of the options.
@jcortes
Copy link
Collaborator Author

jcortes commented Jul 23, 2024

/approve
@jcortes jcortes merged commit 4f710d8 into PipedreamHQ:master Jul 23, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action New Action Request
2 participants
@jcortes @GTFalcao