Added notes table #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjohnmeyer
reviewed
Jun 27, 2023
| case "INSTRUMENT_MIN": | ||
| return "Reflects the minimum amount of an adjustable warrant."; | ||
| default: | ||
| return "There is no specified source for this warrant"; |
There was a problem hiding this comment.
How about "There is no specified source for the amount of this warrant"?
pjohnmeyer
reviewed
Jun 27, 2023
| case "MACHINE_ESTIMATED": | ||
| return "Reflects the machine estimated amount of an adjustable warrant."; | ||
| case "INSTRUMENT_FIXED": | ||
| return "Reflects the fixed amount of an adjustable warrant."; |
There was a problem hiding this comment.
If it's fixed it's not adjustable.
daviidy
commented
Jun 27, 2023
| @@ -35,6 +35,7 @@ class Model implements WorkbookModel { | |||
| private ratioCalculator = new ConversionRatioCalculator(); | |||
| public warrantStockIds: Set<string> = new Set(); | |||
| public nonPlanStockIds: Set<string> = new Set(); | |||
| public warrantsSources = new Map<string, string>(); | |||
There was a problem hiding this comment.
Data structure that contains the warrant stock ids and the corresponding quantity_source
daviidy
commented
Jun 27, 2023
| @@ -65,6 +65,17 @@ class ExcelJSLinePrinter { | |||
| public setColWidth(col: number, width: number) { | |||
| this.worksheet.getColumn(col).width = width; | |||
| } | |||
|
|
|||
| public mergeCells( | |||
There was a problem hiding this comment.
Method to merge cells. Useful for the notes header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SHOW
Fixes issue #50