lib: Fix uninitialized variable issue in shapiroe.c #3994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marisn
approved these changes
Jul 8, 2024
a0x8o
pushed a commit
to a0x8o/grass
that referenced
this pull request
Jul 23, 2024
Co-authored-by: Shubham Vasudeo Desai <sdesai8@vclvm179-2.vcl.ncsu.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the uninitialized variable issue in shapiroe.c identified by cppcheck.
Issues
shapiroe.c:22:17: error: Uninitialized variable: xs [uninitvar]
b = (mean - xs) * sqrt((double)n / (n - 1.0));
^
shapiroe.c:11:19: note: Assuming condition is false
for (i = 0; i < n; ++i)
^
shapiroe.c:22:17: note: Uninitialized variable: xs
b = (mean - xs) * sqrt((double)n / (n - 1.0));
Changes Made
Initialized xs to the first element of the array x to ensure it is properly set before being used in subsequent calculations.