Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checks: Configure isort and enable isort in CI #3968

Closed
wants to merge 4 commits into from

Conversation

echoix
Copy link
Member

@echoix echoix commented Jul 1, 2024

This PRs configures isort in pyproject.toml

It also enables checking in pre-commit and in CI, with suggestions.

To not fail uselessly, these PRs (that fix import sorting) must be merged:

That way, the fixes in the above PRs will stay fixed in future.

@echoix echoix added this to the 8.5.0 milestone Jul 1, 2024
@github-actions github-actions bot added CI Continuous integration Python Related code is in Python labels Jul 1, 2024
@echoix echoix marked this pull request as draft July 1, 2024 21:39
@echoix
Copy link
Member Author

echoix commented Jul 1, 2024

I found out that I can further tune the config files for isort, and the output isn't exactly the same. I want to figure this out before pushing for the PRs

@echoix
Copy link
Member Author

echoix commented Jul 9, 2024

I'm dropping all of these PRs concerning isort for now... I already removed these from my working branch as there were too many conflicts, and I'll end up adding an exclusion for the pylint violations instead.

I might reconsider later, I will still be keeping the changes in a branch somewhere

@echoix echoix closed this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration Python Related code is in Python
1 participant