g.region: add JSON support #3941
Open
+278
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 tasks
cwhite911
suggested changes
Jul 9, 2024
There was a problem hiding this comment.
@kritibirda26 please address the comments I left in the review and add tests to make sure the JSON format respects the various flag combinations.
| } | ||
| } | ||
|
|
||
| /* flag.gmt_style */ | ||
| if (print_flag & PRINT_GMT) | ||
| if ((print_flag & PRINT_GMT) && format != JSON) |
There was a problem hiding this comment.
The json format should work with GMT and WMS print flags.
There was a problem hiding this comment.
What should be the output format in case of the GMT and WMS flags used with JSON respectively?
There was a problem hiding this comment.
The outputs can match what is returned from the plain and shell formats.
{
"GMT": "629970/645000/215010/228540",
"WMS": "bbox=629970,215010,645000,228540"
}
github-actions
bot
added
Python
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using parson, add JSON support to g.region module.
The output looks like as follows:
{ "projection": 99, "zone": 0, "region": { "north": 228500, "south": 215000, "west": 630000, "east": 645000, "ns-res": 10, "ns-res3": 10, "ew-res": 10, "ew-res3": 10 }, "top": 1, "bottom": 0, "tbres": 1, "rows": 1350, "rows3": 1350, "cols": 1500, "cols3": 1500, "depths": 1, "cells": 2025000, "cells3": 2025000 }The interaction of format option with existing flags needs more looking into. We may want to disallow some combinations.
I will add tests and update documentation once the JSON format is finalized.