Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxGUI: Add the ProjPicker page to the Location Wizard (Continutation) #1891

Open
wants to merge 56 commits into
base: main
Choose a base branch
from

Conversation

ocsmit
Copy link
Contributor

@ocsmit ocsmit commented Sep 26, 2021

This pull request is a continuation of the work of #1770 in addressing #1253 to add a location wizard which is spatially queryable.

The goals/scope of the continuation are

  • Inclusion of toolbar for users. 1
  • Smoother OSM map loading (e.g. lazy loading, separate thread, ...). 2
  • Merge with standard EPSG search wizard. 2

@HuidaeCho Feel free to add anything I missed!

HuidaeCho and others added 30 commits August 2, 2021 06:05
…suming that none of projpicker modules will be imported from their installation directory
@HuidaeCho HuidaeCho marked this pull request as ready for review May 20, 2022 22:10
@HuidaeCho
Copy link
Member

HuidaeCho commented May 21, 2022

Flake8 is happy with

l, r = 1, 2

but not with

l, O = 1, 2

and

l = 1
r = 2

Inconsistency... As a result, we have inconsistent naming.

  • l, r, t, b
  • le, ri, to, bo
  • left, right, top, bottom
  • n, s, w, e
  • north, south, west, east

Many short variable names fail Pylint testing because this new module is not excluded from .pylintrc.

@HuidaeCho
Copy link
Member

Working on pylint...

@wenzeslaus wenzeslaus modified the milestones: 8.3.0, 8.4.0 Feb 10, 2023
@HuidaeCho HuidaeCho self-assigned this Nov 10, 2023
@github-actions github-actions bot added Python Related code is in Python libraries labels Jan 9, 2024
@wenzeslaus wenzeslaus modified the milestones: 8.4.0, Future Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request GUI wxGUI related libraries Python Related code is in Python
5 participants