Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting fixes for already merged queries. #3064

Merged
merged 3 commits into from
Aug 14, 2022
Merged

Linting fixes for already merged queries. #3064

merged 3 commits into from
Aug 14, 2022

Conversation

tunetheweb
Copy link
Member

@tunetheweb tunetheweb commented Aug 14, 2022 •
edited
Loading

Includes following changes

  • Correction to ecommerce queries checked in, in Ecommerce 2022 queries #2958 - only noticed after merging as lastest linting only ran then.
  • Correction to CSS queries to noqa July datasets as using non-standard month

The dataset check was only recently released in SQLFluff and many branches were started before that update. Might see a few more of these.
@tunetheweb tunetheweb added the analysis Querying the dataset label Aug 14, 2022
@tunetheweb tunetheweb added this to the 2022 Analysis milestone Aug 14, 2022
@tunetheweb tunetheweb added this to In Progress in 2022 via automation Aug 14, 2022
@tunetheweb tunetheweb changed the title Fix eCommerce query using wrong month for 2021 Aug 14, 2022
@tunetheweb tunetheweb changed the title Checked in queries linting fixes Aug 14, 2022
@tunetheweb tunetheweb merged commit 42d7f5e into main Aug 14, 2022
@tunetheweb tunetheweb deleted the correct-ecommerce-stats branch August 14, 2022 21:53
2022 automation moved this from In Progress to Done Aug 14, 2022
@tunetheweb
Copy link
Member Author

FYI @rviscomi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analysis Querying the dataset
1 participant
@tunetheweb