Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent Pocket New Tab section styling #392

Draft
wants to merge 6 commits into
base: ESR115
Choose a base branch
from
Draft

Consistent Pocket New Tab section styling #392

wants to merge 6 commits into from

Conversation

dominichayesferen
Copy link
Contributor

@dominichayesferen dominichayesferen commented Aug 22, 2023 •
edited
Loading

Check list

  • Referenced all related issues
  • Have tested the modifications

Closes #375
This pull request adds consistent styling for the Pocket section of the New Tab page of Floorp, fixing the inconsistent, and unfitting, upstream Firefox styling of the section.

BEFORE:
Screenshot_20230822_160300

AFTER:
Screenshot_20230822_160327
@dominichayesferen
Copy link
Contributor Author

BEFORE (Light):
Screenshot_20230822_160438

AFTER (Light):
Screenshot_20230822_160456
@surapunoyousei surapunoyousei self-requested a review August 22, 2023 16:05
surapunoyousei
surapunoyousei requested changes Aug 23, 2023
View reviewed changes
browser/components/newtab/css/activity-stream-linux.css
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. This code not recommend to use.

Use NodeJS to fix this problem. But nice try.

info: https://firefox-source-docs.mozilla.org/browser/components/newtab/docs/index.html
floorp/browser/themes/designs/lepton/leptonContent.css Outdated Show resolved Hide resolved
@surapunoyousei
Copy link
Member

surapunoyousei commented Aug 23, 2023 •
edited
Loading

This addition need compatibly with this option.
image

Do not afraid. If you want to know more infomation please reply me.

"browser.newtabpage.activity-stream.floorp.newtab.backdrop.blur.disable" is the preferences name inside of Floorp.

0134bd1
@dominichayesferen
Copy link
Contributor Author

dominichayesferen commented Aug 23, 2023 •
edited
Loading

This addition need compatibly with this option. image

Do not afraid. If you want to know more infomation please reply me.

"browser.newtabpage.activity-stream.floorp.newtab.backdrop.blur.disable" is the preferences name inside of Floorp.

0134bd1

Technically even in its current state it should be compatible with that option as https://github.com/Floorp-Projects/Floorp/pull/392/files#diff-4642bd075b745a271220b1901a3f782ed2570a5ba85b78b5ea0e1159cfbe3f4dR2721 makes sure the blur has the same selector condition as the top sites blur does (in testing, this was also the case).

Either way, I'll mark it as draft for now and convert it to the correct files later.
@dominichayesferen dominichayesferen marked this pull request as draft August 23, 2023 12:46
@creeper-0910 creeper-0910 force-pushed the ESR115 branch 2 times, most recently from 04d8889 to 5354000 Compare June 12, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@dominichayesferen @surapunoyousei