Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add security warning for disabling notifications #1139

Merged
merged 1 commit into from
Jul 4, 2024
Merged

feat: add security warning for disabling notifications #1139

merged 1 commit into from
Jul 4, 2024

Conversation

he3als
Copy link
Member

@he3als he3als commented Jul 3, 2024

Questions

Describe your pull request

Adds info and a prompt to the user about the security implications of disabling notification services.

Disabling notifications means all notifications, including system ones.
This includes notifications that notify you about security updates.

This doesn't improve performance.

Would you like to continue anyways? [Y/N]
@he3als he3als requested a review from Xyueta as a code owner July 3, 2024 20:42
@github-actions github-actions bot added the playbook Playbook related issues/PRs label Jul 3, 2024
@he3als he3als merged commit c797453 into main Jul 4, 2024
2 checks passed
@he3als he3als deleted the notifs-security-warn branch July 4, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
playbook Playbook related issues/PRs
3 participants
@he3als @RadNotRed @PencilNavigator