Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#43866 closed defect (bug) (fixed)

JSDoc: wp-includes/js/media/controllers/gallery-edit.js

Reported by: manuelaugustin's profile manuelaugustin Owned by: atimmer's profile atimmer
Milestone: 5.1 Priority: normal
Severity: normal Version:
Component: Media Keywords: has-patch
Focuses: docs, javascript Cc:

Description

Please give props to @Xyfi @nataliashitova @igorsch @ireneyoast @manuelaugustin

Attachments (1)

gallery-edit.diff​ (4.3 KB) - added by manuelaugustin 6 years ago.

Download all attachments as: .zip

Change History (12)

@manuelaugustin
6 years ago

#1 @joemcgill
6 years ago

  • Focuses changed from docs javascript to docs, javascript
  • Milestone changed from Awaiting Review to 4.9.6
  • Owner set to joemcgill
  • Status changed from new to accepted

Thanks @manuelaugustin and all who contributed. Adding to the next minor release milestone.

This ticket was mentioned in ​Slack in #core-media by joemcgill. ​View the logs.
6 years ago

#3 @netweb
6 years ago

  • Keywords has-patch added
  • Milestone changed from 4.9.6 to 5.0

Let's keep all the ​JSDocs Initiative in the 5.0 milestone, it is one less backport commit to have to worry about.

#4 @atimmer
6 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 43141:

Docs: Improve JSDoc for media/controllers/gallery-edit.js.

Props Xyfi, nataliashitova, igorsch, ireneyoast, manuelaugustin.
Fixes #43866.

#5 @atimmer
6 years ago

In 43142:

Docs: Improve JSDoc for media/controllers/gallery-edit.js.

Amends [43141] - includes the built media files.

See #43866.

#6 @johnbillion
6 years ago

  • Milestone changed from 5.0 to 5.0.1
  • Resolution fixed deleted
  • Status changed from closed to reopened

#7 @pento
6 years ago

  • Milestone changed from 5.0.1 to 5.0.2

#8 @pento
6 years ago

  • Milestone changed from 5.0.2 to 5.0.3

#9 @joemcgill
6 years ago

  • Owner changed from joemcgill to atimmer
  • Status changed from reopened to assigned

Reassigning to @atimmer to consolidate with other JSDoc tickets.

#10 @audrasjb
6 years ago

  • Milestone changed from 5.0.3 to 5.1

Hi,

Per today's bug scrub, we are going to address Docs enhancements in 5.1, coming next month.

#11 @atimmer
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

As this has landed in trunk and 5.1 will release everything in trunk, I'll close this.

Note: See TracTickets for help on using tickets.