Closed
Bug 1898565
Opened 2 months ago
Closed 2 months ago
Add missing quotes in error message for invalid header value in network.continueRequest
Categories
(Remote Protocol :: WebDriver BiDi, defect, P2)
Remote Protocol
WebDriver BiDi
Tracking
(firefox128 fixed)
RESOLVED
FIXED
128 Branch
| Tracking | Status | |
|---|---|---|
| firefox128 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
(Blocks 1 open bug)
Details
(Whiteboard: [webdriver:m11])
Attachments
(1 file)
I introduced slightly inconsistent error messages between invalid header names and values:
`Expected "header" name to be a valid HTTP token, got ${deserializedHeader[0]}`
`Expected header value to be a valid header value, got ${deserializedHeader[1]}`
We are missing " around header in the second message, it would be better to fix it since Puppeteer will use the error message in their implemenation to detect header issues.
|
Assignee | |
Comment 1•2 months ago
|
||
Depends on D210518
|
||
Updated•2 months ago
|
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2e388b7f6f91 [bidi] Add quotes in message for invalid header value in network.continueRequest r=webdriver-reviewers,jgraham
|
||
Comment 3•2 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox128:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
|
||
Comment 4•2 months ago
|
||
Backed out for causing high frequency failures at url_patterns.py
Backout link: https://hg.mozilla.org/integration/autoland/rev/c5f0d71de69cf598d009f69c9ddf56fb6058bc9e
Failure log: https://treeherder.mozilla.org/logviewer?job_id=459502969&repo=autoland&lineNumber=128070
Status: RESOLVED → REOPENED
status-firefox128:
fixed → ---
Resolution: FIXED → ---
Target Milestone: 128 Branch → ---
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/46472 for changes under testing/web-platform/tests
Upstream PR merged by moz-wptsync-bot
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/03d67eccec8f [bidi] Add quotes in message for invalid header value in network.continueRequest r=webdriver-reviewers,jgraham
|
||
Comment 8•2 months ago
|
||
| bugherder | ||
Status: REOPENED → RESOLVED
Closed: 2 months ago → 2 months ago
status-firefox128:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
|
||
Updated•18 days ago
|
Severity: -- → S3
Points: --- → 1
Priority: -- → P2
Whiteboard: [webdriver:m11]
You need to log in
before you can comment on or make changes to this bug.
Description
•