Closed Bug 1893608 Opened 3 months ago Closed 3 months ago

Error this.postData is undefined for requests with postData

Categories

(Remote Protocol :: WebDriver BiDi, defect, P2)

Product:
Remote Protocol
Component:
WebDriver BiDi
Type:
defect
Points:
2

Tracking

(firefox-esr115 unaffected, firefox126 unaffected, firefox127 fixed)

Status:
RESOLVED FIXED
Milestone:
127 Branch
Tracking Flags:
Tracking Status
firefox-esr115 --- unaffected
firefox126 --- unaffected
firefox127 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

(Blocks 3 open bugs, Regression)

Details

(Keywords: regression, Whiteboard: [webdriver:m11])

Attachments

(2 files)

Bug 1893608 - [remote] Fix error this.postData is undefined in NetworkRequest class
48 bytes, text/x-phabricator-request
Details | Review
Bug 1893608 - [wdspec] Add bidi network test for request bodysize
48 bytes, text/x-phabricator-request
Details | Review

I made a mistake in Bug 1893117:

  get postDataSize() {
    return this.#postData ? this.postData.size : 0;
  }

This should be

  get postDataSize() {
    return this.#postData ? this.#postData.size : 0;
  }
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED

We do not have any test checking requests with postData, and due to a technical limitation we only have this field available in the
response events, so the error from my previous patch went unnoticed.

Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/459f4f36d217
[remote] Fix error this.postData is undefined in NetworkRequest class r=webdriver-reviewers,Sasha
https://hg.mozilla.org/integration/autoland/rev/cb85547a6509
[wdspec] Add bidi network test for request bodysize r=webdriver-reviewers,Sasha
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/45930 for changes under testing/web-platform/tests

https://hg.mozilla.org/mozilla-central/rev/459f4f36d217
https://hg.mozilla.org/mozilla-central/rev/cb85547a6509

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
status-firefox127: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch
Upstream PR merged by moz-wptsync-bot
Points: 1 → 2
Whiteboard: [webdriver:m11]
Whiteboard: [webdriver:m11] → [webdriver:m11][webdriver:relnote]
No longer depends on: 1893117
Keywords: regression
Regressed by: 1893117
Whiteboard: [webdriver:m11][webdriver:relnote] → [webdriver:m11]

Set release status flags based on info from the regressing bug 1893117

status-firefox126: --- → unaffected
status-firefox-esr115: --- → unaffected
You need to log in before you can comment on or make changes to this bug.