Closed Bug 1893223 Opened 3 months ago Closed 2 months ago

Some marionette manifests are not included by the master manifest

Categories

(Testing :: Marionette Client and Harness, task, P3)

task
Points:
2

Tracking

(firefox128 fixed)

RESOLVED FIXED
128 Branch
Tracking Status
firefox128 --- fixed

People

(Reporter: gbrown, Assigned: whimboo)

References

(Blocks 1 open bug)

Details

(Whiteboard: [webdriver:m11])

Attachments

(1 file)

In bug 1892038 we noticed that some marionette tests could not be run in CI because they were not included in testing/marionette/harness/marionette_harness/tests/unit-tests.toml. It is not clear to me if all marionette manifests should be included there or not, so just noting here for someone to review and consider.

https://searchfox.org/mozilla-central/search?q=&path=marionette**manifest*.toml&case=true&regexp=false

Is this a correct assessment of the issue? It is surprising to learn that the file needs to be listed here. In other test types, listing it in the directory-specific toml file is enough for it to be picked up in CI.

I previously wondered about the test selection behavior (locally) at https://phabricator.services.mozilla.com/D196188#6507426

If it ultimately turns out that the test needs to be listed in unit-tests.toml, then that should be documents.

See Also: → 1892038

As we discussed we do not have the time to change the underlying packaging behavior for Marionette tests. As such we suggest that the unit-test.toml file gets updated so that it contains all the missing references to tests that are not run yet in CI. As suggested we should also document that and maybe this could directly be done in the same file.

Severity: -- → S3
Priority: -- → P3
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Attachment #9403134 - Attachment description: WIP: Bug 1893223 - [marionette] Fix master manifest for in-tree Marionette tests. → Bug 1893223 - [marionette] Fix master manifest for in-tree Marionette tests.
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b609a929be9f
[marionette] Fix master manifest for in-tree Marionette tests. r=webdriver-reviewers,application-update-reviewers,Sasha,nalexander

Backed out for causing marionette failures on test_exitcode.py.

Flags: needinfo?(hskupin)

That's interesting. This test was running before as well and did not fail. My patch only changed the order between the update and the XRE tests. And I have to admit that I missed to have a final check for the try build results. There it's failing as well but only for MacOS and no other platform. I'll take a look what's wrong here. Most likely that the update tests do not correctly clean-up.

Flags: needinfo?(hskupin)

I filed bug 1898477 to cover the specific test failure that happens when the update test is run before the xre test. For now I will keep the update test to run as last test to prevent that.

Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a9f0952d79a4
[marionette] Fix master manifest for in-tree Marionette tests. r=webdriver-reviewers,application-update-reviewers,Sasha,nalexander
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
Points: --- → 2
Whiteboard: [webdriver:m11]
You need to log in before you can comment on or make changes to this bug.