Clicking on the label in the copy or download button in the Screenshots preview dialog does nothing
Categories
(Firefox :: Screenshots, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox127 | --- | verified |
People
(Reporter: sfoster, Assigned: niklas)
References
Details
Attachments
(1 file)
STR:
- Use ctrl+shift+s or the screenshots toolbar button or the context menu to open the Screenshots UI on any page
- Click either the Save Visible or Save Full Page
- In the resulting preview dialog, click on the "copy" or "dialog" text rather than the icon in either of the buttons
ER:
- The screenshot is copied or downloaded
AR:
- Nothing happens. Its necessary to click on the icon to actually copy/download.
Ultimately the best fix here is to use moz-button and moz-button-group for these buttons. We have all this custom css in/around .preview-button which isn't great.
But, specifically, the issue here is that we shouldn't be overriding the pointer property, and we should remove the pointer-events: none in favor of examining the event.currentTarget rather than event.target in the click event listener.
|
Reporter | |
Comment 1•3 months ago
|
||
Bug 1858812 is adding the moz-button icon + text variation we would need if we wanted to fix this by re-implementing the preview dialog buttons with the resuable components.
|
Assignee | |
Updated•3 months ago
|
|
|
Assignee | |
Comment 2•3 months ago
|
||
|
||
Updated•3 months ago
|
Pushed by nbaumgardner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fd2691d9e2d9 Refactor screenshots preview. r=sfoster,fluent-reviewers,desktop-theme-reviewers,bolsson
|
||
Comment 6•3 months ago
|
||
I can still reproduce this issue on the latest Nightly 127.0a1 - tested on macOS 13. I reproduced it with both Copy and Download options of the Save full page dialog. Please see the screen recording.
Here are the steps that I used.
- Navigated to https://en.wikipedia.org/wiki/Sun
- Restarted Nightly using the key shortcuts Cmd+Shift+J and then Cmd+Option+R
- On the Wiki page - enable Screenshots using Cmd+Shift+S
- Quickly clicked on the Save full page and then on the Copy button
Actual results - the Preview dialog is dismissed, no 'Screenshot copied' notification is shown and the screenshot is not copied. Please keep in mind that the issue is intermittent.
Niklas, should this issue be reopened, or is it best if I log a new one?
|
|
Assignee | |
Comment 7•3 months ago
|
||
I'll file a new bug for this.
I think what's happening is that the copy button is clicked before the image is fully loaded and it's causing some issues.
Because if I wait for the image to show and then copy, it seems to work.
Thanks for finding this!!
|
|
||
Comment 8•2 months ago
|
||
Marking this as Verified Fixed as the issue from the Description is no longer reproducible using the latest Nightly 127.0a1 - tested on Windows 10, Ubuntu 23.10 and macOS 13.
Description
•