"GeckoViewTabUtil.createNewTab()" returns too early causing an ongoing navigation never to finish
Categories
(GeckoView :: General, defect)
Tracking
(firefox127 fixed)
| Tracking | Status | |
|---|---|---|
| firefox127 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [webdriver:m11])
Attachments
(1 file)
Over on bug 1771012 the GeckoViewTabUtil.createNewTab() API has been added to allow testing code like Marionette for wpt tests to open a new tab in any GeckoView application.
As discovered on bug 1522790 comment 53 there is a race condition which let thousands of wpt tests intermittently timeout when the actual test page gets loaded. This happens because the method returns too early and concurrent navigations (initial page load + load of the test page) seem to break the progress listener. The underlying reason for this would need to be investigated and I'll file a separate bug under DOM given that we have similar issues on desktop as well, whereby there it's happening way lesser.
To fix this API I'm proposing to exchange the currently used geckoview-window-created notification with the browser-delayed-startup-finished one, which actually indicates that the window has been finished loading. Then with my patch on bug 1522790 we will wait long enough to not trigger the racy path, and that will allows us to remove around 14.000 intermittent timeout meta data entries across all wpt tests!
|
Assignee | |
Comment 2•3 months ago
|
||
|
|
Assignee | |
Comment 3•3 months ago
|
||
Further investigation to identify the underlying platform issue will be done over on bug 1837949.
|
|
Assignee | |
Updated•3 months ago
|
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/47366c23dc26 [geckoview] Delay return of "GeckoViewTabUtil.createNewTab()" until window has finished loading. r=geckoview-reviewers,ohall
|
||
Comment 5•3 months ago
|
||
| bugherder | ||
Description
•