Closed Bug 1817820 Opened 1 year ago Closed 3 months ago

Fix race condition in marionette when switchFrame is called during a navigation

Categories

(Remote Protocol :: Marionette, defect, P3)

Product:
Remote Protocol
Component:
Marionette
Version:
Default
Type:
defect
Points:
1

Tracking

(firefox127 fixed)

Status:
RESOLVED FIXED
Milestone:
127 Branch
Tracking Flags:
Tracking Status
firefox127 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

Details

(Whiteboard: [webdriver:m11][webdriver:relnote])

Attachments

(1 file, 1 obsolete file)

Bug 1817820 - [marionette] Retry switch to frame if browsing context changed mid flight
48 bytes, text/x-phabricator-request
Details | Review
Component: geckodriver → Marionette
Product: Testing → Remote Protocol

The severity field is not set for this bug.
:whimboo, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(hskupin)

We will determine the severity in our next triage meeting.

Flags: needinfo?(hskupin)

The severity field is not set for this bug.
:whimboo, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(hskupin)

Just to illustrate the analysis, this fixes the issue. Let's discuss if we want to go for something along those lines

Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Severity: -- → S3
Points: --- → 1
Priority: -- → P3
Status: ASSIGNED → NEW
Flags: needinfo?(hskupin)

Given that this is a fix for Bug 1816061, let's close this as duplicate and move the patch to the appropriate bug

Status: NEW → RESOLVED
Closed: 3 months ago
Duplicate of bug: 1816061
Resolution: --- → DUPLICATE

(In reply to Julian Descottes [:jdescottes] from comment #5)

Given that this is a fix for Bug 1816061, let's close this as duplicate and move the patch to the appropriate bug

Usually we want to use dedicated bugs for fixes, which also makes it easier to spot what needs to be added for release notes. So could we just add the dependency instead for the test failure on Android?

Flags: needinfo?(jdescottes)

(In reply to Henrik Skupin [:whimboo][⌚️UTC+1] from comment #6)

(In reply to Julian Descottes [:jdescottes] from comment #5)

Given that this is a fix for Bug 1816061, let's close this as duplicate and move the patch to the appropriate bug

Usually we want to use dedicated bugs for fixes, which also makes it easier to spot what needs to be added for release notes. So could we just add the dependency instead for the test failure on Android?

Sure. I think we do it by default for single tracking bugs, not really for other intermittents.

Flags: needinfo?(jdescottes)
Status: RESOLVED → REOPENED
No longer duplicate of bug: 1816061
Resolution: DUPLICATE → ---
Status: REOPENED → ASSIGNED
Attachment #9325394 - Attachment is obsolete: true
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6c739d1419fe
[marionette] Retry switch to frame if browsing context changed mid flight r=webdriver-reviewers,whimboo

https://hg.mozilla.org/mozilla-central/rev/6c739d1419fe

Status: ASSIGNED → RESOLVED
Closed: 3 months ago → 3 months ago
status-firefox127: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch
Whiteboard: [webdriver:m11]
Whiteboard: [webdriver:m11] → [webdriver:m11][webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.