Open Bug 1562670 Opened 5 years ago Updated 2 years ago

"Learn more" link in the accessibility service description is not linked in he-il locale

Categories

(DevTools :: Accessibility Tools, defect)

defect

Tracking

(firefox69 fix-optional, firefox70 affected)

Tracking Status
firefox69 --- fix-optional
firefox70 --- affected

People

(Reporter: itiel_yn8, Unassigned)

References

Details

Attachments

(1 file)

Attached image Screenshot

What were you doing?

  1. Install the hebrew locale version of Nightly
  2. On any page, open the devtools (doesn't matter which one)
  3. Go to Accessibility tab
  4. On the description, see the "Learn more" link (in hebrew: מידע נוסף)

What happened?

The text is not linked.

What should have happened?

It should be.

Anything else we should know?

Both relevant strings in Pontoon are translated:
https://pontoon.mozilla.org/he/firefox/all-resources/?string=189732
https://pontoon.mozilla.org/he/firefox/all-resources/?string=189742

:flod, is there anything pontoon-related issue with that that I may have missed?

Flags: needinfo?(francesco.lodolo)

So, what the code does is

  1. Replace %S with the "Learn more" text, resulting in
חוקר הנגישות מאפשר לך לבחון את עץ הנגישות של העמוד הנוכחי, בו משתמשים קוראי מסך ושלל טכנולוגיות מסייעות נוספות. מידע נוסף
  1. Use a regular expression to replace מידע נוסף.

I don't think \b is a valid choice for non ASCII text

const messageString = 'מסייעות נוספות. מידע נוסף';
const learnMoreString = 'מידע נוסף';
const re = new RegExp(`(\\b${learnMoreString}\\b)`);
let contents = messageString.split(re);
print(contents[1]);

/*
undefined
*/
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.