Alexandre Poirot [:ochameau] Assignee
	Description • 6 years ago

Per the following RFC:
  https://github.com/devtools-html/rfcs/issues/48
And in order to unblock Promise.jsm removal and especially allow landing bug 1388054, we should refactor main.js to stop being evaluated as a document script, but rather it be loaded as a module, via DevTools module loader.

	Alexandre Poirot [:ochameau] Assignee
	Comment 2 • 6 years ago

Compared to bug 1470086, I've been a litlle bit more conservative.
I've not changed the EventEmitter target. I've let `window` be the target.
It isn't clear if we should make it be `panel` or another object... It also looks slightly outside of the scope of initialization ;)
But it would be great to standardize this practice as well!

	Julian Descottes [:jdescottes]
	Comment 3 • 6 years ago
mozreview-review

Comment on attachment 8987784 [details]
Bug 1471161 - Standardize Accessibility panel initialization.

https://reviewboard.mozilla.org/r/253060/#review259764

::: devtools/client/jar.mn
(Diff revision 1)
>      content/aboutdebugging/aboutdebugging.xhtml (aboutdebugging/aboutdebugging.xhtml)
>      content/aboutdebugging/aboutdebugging.css (aboutdebugging/aboutdebugging.css)
>      content/responsive.html/index.xhtml (responsive.html/index.xhtml)
>      content/dom/index.html (dom/index.html)
>      content/accessibility/index.html (accessibility/index.html)
> -    content/accessibility/main.js (accessibility/main.js)

Still referenced in devtools/client/accessibility/index.html

	Yura Zenevich [:yzen] (please use "needinfo")
	Comment 4 • 6 years ago
mozreview-review

Comment on attachment 8987784 [details]
Bug 1471161 - Standardize Accessibility panel initialization.

https://reviewboard.mozilla.org/r/253060/#review261354

Thanks! r+ with Julian's comment addressed.