Isabel Rios[:isabel_rios] Assignee
	Description • 6 years ago

The idea is to have a file with a list of URLs (long list, around 5000 entries) and have a test that can open URLs from there.

This test is not meant to be run in daily basis, so it will be disabled. This is just a test as a helping tool if at some point it is necessary to load lots of different websites or random websites for different uses.

Please see also bug 1442374. There we will have an exising DB that can be used for other different tests where an exisiting DB has to be used but that test does not generate the DB it only loads it to check that we can manage big browser DBs.

	Isabel Rios[:isabel_rios] Assignee
	Comment 1 • 6 years ago

Please let me know if this is similar to what you have in mind...

	James Hugman [:jhugman] [@jhugman]
	Comment 2 • 6 years ago

Comment on attachment 8959562 [details] [review]
Pull Request

Quite a few questions about this PR, but I think you're on the right track.

	Isabel Rios[:isabel_rios] Assignee
	Comment 3 • 6 years ago

Thanks for the review! I made some changes and added new tests to cover some scenarios you were missing according to your comments.

I also added a way to retrieve and store the database(s) generated in each test. But there I'm stuck because it works locally selecting the correct path, but it will not work in another environment. That's why you will see that part with comments to specify the path. There should be a way to specify a general path and then take the browser.db file but I have not found the way to do it correctly yet.

	No-Jun Park [:njpark]
	Comment 4 • 6 years ago

Comment on attachment 8959562 [details] [review]
Pull Request

Looks good, should we put those tests that are not verifying the correctness of the app in a separate folder to group them better?  (i.e. a subfolder) it's your call.  (oh and squashing commits would be nice too)

	Isabel Rios[:isabel_rios] Assignee
	Comment 5 • 6 years ago

Comment on attachment 8959562 [details] [review]
Pull Request

Removing the review for now since there is not ongoing work on this bug and it will requiere some updates before asking for review again