Open
Bug 1439577
Opened 7 years ago
Updated 2 years ago
Deprecate MMNavigator extension methods.
Categories
(Firefox for iOS :: Build & Test, enhancement, P3)
Tracking
()
NEW
Tracking | Status | |
---|---|---|
fxios | + | --- |
People
(Reporter: jhugman, Unassigned, Mentored)
Details
(Whiteboard: [TechnicalDebt])
Currently we are using an extension for FxScreenGraph.navigator which does not use ScreenActions, but instead synthesizes the desired effect from a combination of navigating to a ScreenState and then imperatively performing the action. This should use the more generic performAction so that it's visible on the graph. The first part of this is to add the actions to the graph, and rewrite the extension methods (particularly browserPerformAction) in terms of the new actions. The second part of this would be to deprecate the extension methods: @available(*, deprecated, message: "use performAction instead") If the call sites for these methods can be replaced with a single navigator.performAction(Action.*) call, then this should be done and the method removed.
Reporter | ||
Comment 1•7 years ago
|
||
:irios Would this be something you'd be interested in doing?
Flags: needinfo?(irios)
Whiteboard: [TechnicalDebt]
Comment 2•7 years ago
|
||
Yup, I can take this one but I think that it would be for a medium-long term, if that's ok, happy to take it and help with this
Flags: needinfo?(irios)
Updated•7 years ago
|
Priority: -- → P3
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•