Simon Basca [:SimonB] Reporter
	Description • 8 years ago

Build: 5.1b1
Device: iPhone 6 Plus
iOS: 9.3.3

Steps to reproduce:
1. Log in to Firefox Account 1 with saved logins
2. Save / sync logins on device
3. Log out of Firefox Account 1
4. Log in with another Firefox Account 2 with saved logins

Actual result:

- Logins are merged. This scenario can be a possible security risk considering that the logins can be transferred to a unwanted account when Passcode or Touch ID is set On just by logging in / out action.  

Expected results:

1. - The password should be requested when logging out of account 1 in case of someone wanting to intentionally transfers the logins to another account. 
 
2. - After logging out of account 1 and logging in with account 2 a prompt message should be displayed informing the user that the existing logins are merged with the ones existing on account 2. If the user wishes to continue this action then the logins password should be request (in the event that) if not the logins on the device should be deleted and logging in to account 2 should proceed.

	Richard Newman [:rnewman]
	Comment 1 • 8 years ago

This is what Bug 1162778 (and the design part, Bug 1183693) are intended to address. Bug 1162778 Comment 5 gives some other scenarios, and outlines this one:

---
* I'm switching accounts. Perhaps I want to take the data on this device with me (I changed email addresses), or perhaps I want to start from scratch on this device with whatever is in the new account.
---

It seems reasonable to me to additionally request touch ID/passcode when signing in to a Sync account that has password sync enabled.

	Thomas Whaples
	Comment 2 • 8 years ago

Mozilla Fennec does not have a gmail.com address. un-CC-ing myself.

	Justin D'Arcangelo [:justindarc]
	Comment 4 • 7 years ago

Ryan, what do you think of Richard's suggestion in Comment 1?:

"It seems reasonable to me to additionally request touch ID/passcode when signing in to a Sync account that has password sync enabled."

	Ryan Feeley [:rfeeley]
	Comment 6 • 7 years ago

Is there not a merge warning on iOS like there is on desktop? See attached.

	Justin D'Arcangelo [:justindarc]
	Comment 7 • 7 years ago

(In reply to Ryan Feeley [:rfeeley] from comment #6)
> Created attachment 8881542 [details]
> Screenshot 2017-06-27 14.54.15.png
> 
> Is there not a merge warning on iOS like there is on desktop? See attached.

As far as I can tell, we don't have this. I searched the project and we don't have strings for it yet either.

Also, the concern here wouldn't be resolved by a dialog like that. The concern is that if someone gets a hold of your unlocked phone, they can sign you out and sign themselves in to Firefox which would merge all of your datas to their account.