Lina Butler [:lina] Reporter
	Description • 9 years ago

https://dxr.mozilla.org/mozilla-central/rev/cc473fe5dc512c450634506f68cbacfb40a06a23/dom/fetch/Fetch.cpp#1072-1081 can be simplified using the variant `Promise::MaybeReject(ErrorResult&)` (https://dxr.mozilla.org/mozilla-central/rev/cc473fe5dc512c450634506f68cbacfb40a06a23/dom/promise/Promise.h#129-132).

	Boris Zbarsky [:bzbarsky]
	Comment 1 • 9 years ago

This was blocking my patches for bug 1224007, so I ended up just fixing it....

	Sunny Sidhu Assignee
	Comment 2 • 9 years ago

Hi Kit 

Can you please provide feedback on my patch, also can you tell me how I can test these?

	Lina Butler [:lina] Reporter
	Comment 3 • 9 years ago

Comment on attachment 8688528 [details] [diff] [review]
rev1 - Applies simplification in Fetch.cpp

Review of attachment 8688528 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, looks good!

You'll need access to the Try server to test out your change. Please file a bug for Level 1 commit access (https://www.mozilla.org/en-US/about/governance/policies/commit/) and needinfo? me; I'll vouch for you. If you installed the Mozilla VCS tools with `mach mercurial-setup`, you can then trigger a Try run with `hg push-to-try -m "try: trychooser-syntax"`. Here's a cheat sheet for the syntax: http://trychooser.pub.build.mozilla.org/

	Sunny Sidhu Assignee
	Comment 4 • 9 years ago

(In reply to Kit Cambridge [:kitcambridge] from comment #3)
> Comment on attachment 8688528 [details] [diff] [review]
> rev1 - Applies simplification in Fetch.cpp
> 
> Review of attachment 8688528 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Thanks, looks good!
> 
> You'll need access to the Try server to test out your change. Please file a
> bug for Level 1 commit access
> (https://www.mozilla.org/en-US/about/governance/policies/commit/) and
> needinfo? me; I'll vouch for you. If you installed the Mozilla VCS tools
> with `mach mercurial-setup`, you can then trigger a Try run with `hg
> push-to-try -m "try: trychooser-syntax"`. Here's a cheat sheet for the
> syntax: http://trychooser.pub.build.mozilla.org/

All done! 

Thank you for your help. :)

	Sunny Sidhu Assignee
	Comment 5 • 9 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b64baa99c97d

	Boris Zbarsky [:bzbarsky]
	Comment 6 • 9 years ago

Fixed by the patches in bug 1224007.

	Lina Butler [:lina] Reporter
	Comment 7 • 9 years ago

Sorry I missed this. :-( Looks like :bz's patch series landed first. Thanks for contributing, though!