AHK script is unstable while running

Question

I am working in a External HDD manufacturing company. I have requirement to upgrade the FW for thousands of HDDs. I have to upload two files in sequence to get the upload completed. To do manual processing takes time as well as allows chance of Human error. So I decided to automate the key strokes and mouse clicks using Auto Hot Key. I have also compiled the script. However the script is unstable. Sometimes it works fine. Some times the control click don't work. Sometimes the key input won't be typed full. But the script is OK based on my knowledge. If there is any mistake please correct me. Also I want to safe remove the drive so if there is any coding for it please add it up as well

My process is explanation is as below.

1. Connect the HDD to PC and Wait PC to Detect HDD
2. Open the FW upload tool
3. Click RESCAN and wait for HDD to show up in the tool
4. Click browse for first FW file.
5. Then select the check box near HDD shown in the tool.
6. Click DOWNLOAD and press enter at next warning message.
7. Wait for Download to finish and press OK after success message shown.
8. Repeat step 3 to 7 for second FW file.
9. Click exit and Safe remove the HDD.

Below is my script.

Run, open "Application Location"
Winwait, Warning
if ErrorLevel
{
    MsgBox, Window timed out.
    return
}
else
{
ControlClick, OK, Warning
Winwait, Application Window name
if ErrorLevel
{
    MsgBox, WinWait timed out.
    return
}
else
{
; Upload first FW File
ControlClick, Rescan, Application Window name
ControlClick, Browse, Application Window name
Winwait, Open
if ErrorLevel
{
    MsgBox, WinWait timed out.
    return
}
else
{
SendInput, {Raw}Location of First File
Send, {Enter}
}
sleep, 1500
WinActivate, Application Window name
CoordMode, Mouse, Relative
Click 43, 126
ControlClick, Download, Application Window name
Winwait, Warning
if ErrorLevel
{
    MsgBox, WinWait timed out.
    return
}
else
{
Send, {Enter}
}
Winwait, Download Successful
if ErrorLevel
{
    MsgBox, WinWait timed out.
    return
}
else
{
ControlClick, OK, Download Successful
}
}
; Upload Second FW File
WinActivate, Application Window name
ControlClick, Rescan, Application Window name
ControlClick, Browse, Application Window name
Winwait, Open
if ErrorLevel
{
    MsgBox, WinWait timed out.
    return
}
else
{
SendInput, {Raw}Second FW File location
Send, {Enter}
}
sleep, 1500
WinActivate, Application Window name
CoordMode, Mouse, Relative
Click 43, 126
sleep, 2000
ControlClick, Download, Application Window name
Winwait, Warning
if ErrorLevel
{
    MsgBox, WinWait timed out.
    return
}
else
{
Send, {Enter}
}
Winwait, Download Successful
if ErrorLevel
{
    MsgBox, WinWait timed out.
    return
}
else
{
ControlClick, OK, Download Successful
sleep, 1500
ControlClick, Exit, Application Window name
}
}

Answer 1

A few thoughts:

1. If you return on error level in the first few lines, no need to encapsulate the rest of the script in an Else statement and encapsulating brackets. Not needed.

2. The use of WinWait is not the same as WinWaitActive. A window can exist without being active, so always use WinWaitActive unless you need to look for a window in the background. Using WinWait can cause your script execution to continue past the wait statement before the window is actually active, causing some of the problems you're describing.

3. Unless there is a need to switch between Send and SendInput, stick to one or the other... usually SendInput is the more preferable option for reasons explained in the help files. Using both of them (depending on the program being used) can cause timing issues as to how the keys get sent.

4. Use WinWaitActive after any instances of WinActivate to make sure the window is active before continuing.

5. For code that gets repeated, try using a subroutine, i.e., gosub or function call. Since the file location gets changed you could set the file location with a variable between calls, or use the variable as a parameter of the function call. This would keep you from having to re-write everything twice if you change the routine.