14

In a bash script, how can I say 'for all files of type .png or .PNG'?

I'm trying :

for i in (`ls *.PNG` && `ls *.png`)

but getting a syntax error.

3 Answers 3

18

If you want all possible combinations, use:

for i in *.[Pp][Nn][Gg]; do

or

shopt -s nocaseglob
for i in *.png; do

although that one will make all of your script's shell globs (i.e. wildcard file matches) case insensitive until you run shopt -u nocaseglob.

If you really want just .PNG and .png (and not, for example, .PnG or .pnG), then use either

shopt -s nullglob
for i in *.png *.PNG; do

or

for i in *.png *.PNG; do
    [[ -e "$i" ]] || continue

...the reason for the nullglob or existence check is that if you have only lowercase or only uppercase extensions, it'll include the unmatched pattern in the list of files, leading to an error in the body of the loop. As with nocaseglob, you might want to turn the nullglob shell option off afterward (although in my experience having nullglob on is often good, especially in a script). Actually, I rather consider it a good idea to use either the nocaseglob or existence check for all file matches like this, just in case there are no matches.

2
  • 5
    for i in *.{png,PNG} Commented May 16, 2011 at 12:54
  • @glenn: That'd work too (equivalent to `*.png *.PNG), although you still need nullglob or the existence check. Commented May 16, 2011 at 20:24
5

You could also try some one-liner such as

find . -iname "*.png" -exec ....

or

find . -iname "*.png" | xargs ....

Edit
See also @Yab's comment below about recursion.

2
  • 1
    find is however by default recursive, so to get the same result the question asks, you'd have to do find -maxdepth 1 -iname "*.png"
    – Yab
    Commented May 16, 2011 at 6:45
  • @Yab, you are perfectly correct. I overlooked this aspect. Commented May 16, 2011 at 6:51
1

ls is almost useless here but for the record here is a syntax closer to your attempt:

for i in $(ls *.PNG ; ls *.png)

Notes:

  • I'm assuming you want both uppercase and lowercase pictures. The && separator would means process png files only if PNG files exist, which probably doesn't make much sense.
  • you'll have error messages displayed if no files are found with either pattern.

You must log in to answer this question.

Not the answer you're looking for? Browse other questions tagged .